OSDN Git Service

tools lib traceevent: Do not call add_event() again if allocation failed
authorNamhyung Kim <namhyung.kim@lge.com>
Mon, 23 Apr 2012 04:58:34 +0000 (13:58 +0900)
committerNamhyung Kim <namhyung@kernel.org>
Wed, 4 Jul 2012 04:40:31 +0000 (13:40 +0900)
When memory allocation for the field name is failed, do not goto
event_failed since we added the event already.

Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: David Ahern <dsahern@gmail.com>
Link: http://lkml.kernel.org/r/1335157118-14658-8-git-send-email-namhyung.kim@lge.com
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/lib/traceevent/event-parse.c

index 337ca02..99b0cd4 100644 (file)
@@ -4770,7 +4770,8 @@ int pevent_parse_event(struct pevent *pevent,
                        arg->field.name = strdup(field->name);
                        if (!arg->field.name) {
                                do_warning("failed to allocate field name");
-                               goto event_failed;
+                               event->flags |= EVENT_FL_FAILED;
+                               return -1;
                        }
                        arg->field.field = field;
                }