OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5615e08
)
tracing/osnoise: Fix missed cpus_read_unlock() in start_per_cpu_kthreads()
author
Qiang.Zhang
<qiang.zhang@windriver.com>
Tue, 31 Aug 2021 02:29:19 +0000
(10:29 +0800)
committer
Steven Rostedt (VMware)
<rostedt@goodmis.org>
Wed, 8 Sep 2021 19:10:24 +0000
(15:10 -0400)
When start_kthread() return error, the cpus_read_unlock() need
to be called.
Link:
https://lkml.kernel.org/r/20210831022919.27630-1-qiang.zhang@windriver.com
Cc: <stable@vger.kernel.org>
Fixes:
c8895e271f79
("trace/osnoise: Support hotplug operations")
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Signed-off-by: Qiang.Zhang <qiang.zhang@windriver.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_osnoise.c
patch
|
blob
|
history
diff --git
a/kernel/trace/trace_osnoise.c
b/kernel/trace/trace_osnoise.c
index
65b08b8
..
ce05361
100644
(file)
--- a/
kernel/trace/trace_osnoise.c
+++ b/
kernel/trace/trace_osnoise.c
@@
-1548,7
+1548,7
@@
static int start_kthread(unsigned int cpu)
static int start_per_cpu_kthreads(struct trace_array *tr)
{
struct cpumask *current_mask = &save_cpumask;
- int retval;
+ int retval
= 0
;
int cpu;
cpus_read_lock();
@@
-1568,13
+1568,13
@@
static int start_per_cpu_kthreads(struct trace_array *tr)
retval = start_kthread(cpu);
if (retval) {
stop_per_cpu_kthreads();
-
return retval
;
+
break
;
}
}
cpus_read_unlock();
- return
0
;
+ return
retval
;
}
#ifdef CONFIG_HOTPLUG_CPU