OSDN Git Service

ASoC: rt5668: fix incorrect 'and' operator
authorColin Ian King <colin.king@canonical.com>
Thu, 19 Apr 2018 14:34:31 +0000 (15:34 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 19 Apr 2018 14:40:01 +0000 (15:40 +0100)
Currently logical and is being used instead of bitwise and. Fix this.

Detected by CoverityScan, CID#1468008 ("Logical vs bitwise operator")

Fixes: d59fb2856223 ("ASoC: rt5668: add rt5668B codec driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5668.c

index 52a343f..3c19d03 100644 (file)
@@ -1194,7 +1194,7 @@ static int set_filter_clk(struct snd_soc_dapm_widget *w,
        int ref, val, reg, idx = -EINVAL;
        static const int div[] = {1, 2, 3, 4, 6, 8, 12, 16, 24, 32, 48};
 
-       val = snd_soc_component_read32(component, RT5668_GPIO_CTRL_1) &&
+       val = snd_soc_component_read32(component, RT5668_GPIO_CTRL_1) &
                RT5668_GP4_PIN_MASK;
        if (w->shift == RT5668_PWR_ADC_S1F_BIT &&
                val == RT5668_GP4_PIN_ADCDAT2)