OSDN Git Service

ksmbd: Fix smb2_set_info_file() kernel-doc comment
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 21 Dec 2021 09:07:12 +0000 (17:07 +0800)
committerSteve French <stfrench@microsoft.com>
Wed, 29 Dec 2021 04:47:22 +0000 (22:47 -0600)
Fix argument list that the kdoc format and script verified in
smb2_set_info_file().

The warnings were found by running scripts/kernel-doc, which is
caused by using 'make W=1'.
fs/ksmbd/smb2pdu.c:5862: warning: Function parameter or member 'req' not
described in 'smb2_set_info_file'
fs/ksmbd/smb2pdu.c:5862: warning: Excess function parameter 'info_class'
description in 'smb2_set_info_file'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 9496e268e3af ("ksmbd: add request buffer validation in smb2_set_info")
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/ksmbd/smb2pdu.c

index 08ff468..722f14a 100644 (file)
@@ -5848,7 +5848,7 @@ static int set_file_mode_info(struct ksmbd_file *fp,
  * smb2_set_info_file() - handler for smb2 set info command
  * @work:      smb work containing set info command buffer
  * @fp:                ksmbd_file pointer
- * @info_class:        smb2 set info class
+ * @req:       request buffer pointer
  * @share:     ksmbd_share_config pointer
  *
  * Return:     0 on success, otherwise error