OSDN Git Service

gpio: em: Remove error messages on out-of-memory conditions
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 27 May 2019 12:40:50 +0000 (14:40 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Tue, 28 May 2019 15:32:10 +0000 (17:32 +0200)
There is no need to print error messages when memory allocations or
related operations fail, as the core will take care of that.

Change the returned error codes to -ENOMEM to match the failure cause
while at it.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-em.c

index 982e699..18937a9 100644 (file)
@@ -305,16 +305,14 @@ static int em_gio_probe(struct platform_device *pdev)
        p->base0 = devm_ioremap_nocache(&pdev->dev, io[0]->start,
                                        resource_size(io[0]));
        if (!p->base0) {
-               dev_err(&pdev->dev, "failed to remap low I/O memory\n");
-               ret = -ENXIO;
+               ret = -ENOMEM;
                goto err0;
        }
 
        p->base1 = devm_ioremap_nocache(&pdev->dev, io[1]->start,
                                   resource_size(io[1]));
        if (!p->base1) {
-               dev_err(&pdev->dev, "failed to remap high I/O memory\n");
-               ret = -ENXIO;
+               ret = -ENOMEM;
                goto err0;
        }