OSDN Git Service

forcedeth: fix excluded_middle.cocci warnings
authorkernel test robot <lkp@intel.com>
Mon, 2 Nov 2020 08:38:30 +0000 (09:38 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 4 Nov 2020 01:47:04 +0000 (17:47 -0800)
Condition !A || A && B is equivalent to !A || B.

Generated by: scripts/coccinelle/misc/excluded_middle.cocci

Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2011020936100.3077@hadrien
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/nvidia/forcedeth.c

index 7e85cf9..8724d6a 100644 (file)
@@ -1043,8 +1043,7 @@ static int using_multi_irqs(struct net_device *dev)
        struct fe_priv *np = get_nvpriv(dev);
 
        if (!(np->msi_flags & NV_MSI_X_ENABLED) ||
-           ((np->msi_flags & NV_MSI_X_ENABLED) &&
-            ((np->msi_flags & NV_MSI_X_VECTORS_MASK) == 0x1)))
+           ((np->msi_flags & NV_MSI_X_VECTORS_MASK) == 0x1))
                return 0;
        else
                return 1;