OSDN Git Service

drm/amd/display: Simplify bool comparison
authorYang Li <abaci-bugfix@linux.alibaba.com>
Wed, 13 Jan 2021 09:38:27 +0000 (17:38 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 14 Jan 2021 18:20:21 +0000 (13:20 -0500)
Fix the following coccicheck warning:
./drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c:5121:14-38:
WARNING: Comparison to bool

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c

index 86ff24d..0bcec11 100644 (file)
@@ -5121,48 +5121,48 @@ void dml21_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
                for (j = 0; j < 2; j++) {
                        enum dm_validation_status status = DML_VALIDATION_OK;
 
-                       if (mode_lib->vba.ScaleRatioAndTapsSupport != true) {
+                       if (!mode_lib->vba.ScaleRatioAndTapsSupport) {
                                status = DML_FAIL_SCALE_RATIO_TAP;
-                       } else if (mode_lib->vba.SourceFormatPixelAndScanSupport != true) {
+                       } else if (!mode_lib->vba.SourceFormatPixelAndScanSupport) {
                                status = DML_FAIL_SOURCE_PIXEL_FORMAT;
-                       } else if (locals->ViewportSizeSupport[i][0] != true) {
+                       } else if (!locals->ViewportSizeSupport[i][0]) {
                                status = DML_FAIL_VIEWPORT_SIZE;
-                       } else if (locals->DIOSupport[i] != true) {
+                       } else if (!locals->DIOSupport[i]) {
                                status = DML_FAIL_DIO_SUPPORT;
-                       } else if (locals->NotEnoughDSCUnits[i] != false) {
+                       } else if (locals->NotEnoughDSCUnits[i]) {
                                status = DML_FAIL_NOT_ENOUGH_DSC;
-                       } else if (locals->DSCCLKRequiredMoreThanSupported[i] != false) {
+                       } else if (locals->DSCCLKRequiredMoreThanSupported[i]) {
                                status = DML_FAIL_DSC_CLK_REQUIRED;
-                       } else if (locals->ROBSupport[i][0] != true) {
+                       } else if (!locals->ROBSupport[i][0]) {
                                status = DML_FAIL_REORDERING_BUFFER;
-                       } else if (locals->DISPCLK_DPPCLK_Support[i][j] != true) {
+                       } else if (!locals->DISPCLK_DPPCLK_Support[i][j]) {
                                status = DML_FAIL_DISPCLK_DPPCLK;
-                       } else if (locals->TotalAvailablePipesSupport[i][j] != true) {
+                       } else if (!locals->TotalAvailablePipesSupport[i][j]) {
                                status = DML_FAIL_TOTAL_AVAILABLE_PIPES;
-                       } else if (mode_lib->vba.NumberOfOTGSupport != true) {
+                       } else if (!mode_lib->vba.NumberOfOTGSupport) {
                                status = DML_FAIL_NUM_OTG;
-                       } else if (mode_lib->vba.WritebackModeSupport != true) {
+                       } else if (!mode_lib->vba.WritebackModeSupport) {
                                status = DML_FAIL_WRITEBACK_MODE;
-                       } else if (mode_lib->vba.WritebackLatencySupport != true) {
+                       } else if (!mode_lib->vba.WritebackLatencySupport) {
                                status = DML_FAIL_WRITEBACK_LATENCY;
-                       } else if (mode_lib->vba.WritebackScaleRatioAndTapsSupport != true) {
+                       } else if (!mode_lib->vba.WritebackScaleRatioAndTapsSupport) {
                                status = DML_FAIL_WRITEBACK_SCALE_RATIO_TAP;
-                       } else if (mode_lib->vba.CursorSupport != true) {
+                       } else if (!mode_lib->vba.CursorSupport) {
                                status = DML_FAIL_CURSOR_SUPPORT;
-                       } else if (mode_lib->vba.PitchSupport != true) {
+                       } else if (!mode_lib->vba.PitchSupport) {
                                status = DML_FAIL_PITCH_SUPPORT;
-                       } else if (locals->TotalVerticalActiveBandwidthSupport[i][0] != true) {
+                       } else if (!locals->TotalVerticalActiveBandwidthSupport[i][0]) {
                                status = DML_FAIL_TOTAL_V_ACTIVE_BW;
-                       } else if (locals->PTEBufferSizeNotExceeded[i][j] != true) {
+                       } else if (!locals->PTEBufferSizeNotExceeded[i][j]) {
                                status = DML_FAIL_PTE_BUFFER_SIZE;
-                       } else if (mode_lib->vba.NonsupportedDSCInputBPC != false) {
+                       } else if (mode_lib->vba.NonsupportedDSCInputBPC) {
                                status = DML_FAIL_DSC_INPUT_BPC;
-                       } else if ((mode_lib->vba.HostVMEnable != false
-                                       && locals->ImmediateFlipSupportedForState[i][j] != true)) {
+                       } else if ((mode_lib->vba.HostVMEnable
+                                       && !locals->ImmediateFlipSupportedForState[i][j])) {
                                status = DML_FAIL_HOST_VM_IMMEDIATE_FLIP;
-                       } else if (locals->PrefetchSupported[i][j] != true) {
+                       } else if (!locals->PrefetchSupported[i][j]) {
                                status = DML_FAIL_PREFETCH_SUPPORT;
-                       } else if (locals->VRatioInPrefetchSupported[i][j] != true) {
+                       } else if (!locals->VRatioInPrefetchSupported[i][j]) {
                                status = DML_FAIL_V_RATIO_PREFETCH;
                        }