OSDN Git Service

powerpc: get_wchan(): solve possible race scenario due to parallel wakeup
authorKautuk Consul <kautuk.consul.1980@gmail.com>
Tue, 19 Apr 2016 10:18:21 +0000 (15:48 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 6 Oct 2017 09:51:52 +0000 (20:51 +1100)
Add a check for p->state == TASK_RUNNING so that any wake-ups on
task_struct p in the interim lead to 0 being returned by get_wchan().

Signed-off-by: Kautuk Consul <kautuk.consul.1980@gmail.com>
[mpe: Confirmed other architectures do similar]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/process.c

index a0c74bb..166145b 100644 (file)
@@ -1898,7 +1898,8 @@ unsigned long get_wchan(struct task_struct *p)
 
        do {
                sp = *(unsigned long *)sp;
-               if (!validate_sp(sp, p, STACK_FRAME_OVERHEAD))
+               if (!validate_sp(sp, p, STACK_FRAME_OVERHEAD) ||
+                   p->state == TASK_RUNNING)
                        return 0;
                if (count > 0) {
                        ip = ((unsigned long *)sp)[STACK_FRAME_LR_SAVE];