OSDN Git Service

perf header: Delete an unnecessary check before the calling free_event_desc()
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 25 Jun 2015 15:12:32 +0000 (17:12 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 25 Jun 2015 18:15:49 +0000 (15:15 -0300)
The free_event_desc() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/558C2ABA.3000603@users.sourceforge.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/header.c

index 21a77e7..03ace57 100644 (file)
@@ -1063,8 +1063,7 @@ out:
        free(buf);
        return events;
 error:
-       if (events)
-               free_event_desc(events);
+       free_event_desc(events);
        events = NULL;
        goto out;
 }