OSDN Git Service

Fix mutex_trylock() copy-and-paste bug (x86, x86-64, generic mutex-dec.h)
authorLinus Torvalds <torvalds@g5.osdl.org>
Wed, 11 Jan 2006 23:50:47 +0000 (15:50 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 11 Jan 2006 23:50:47 +0000 (15:50 -0800)
Noticed by Arjan originally on x86-64, then Ingo on x86, and finally me
grepping for it in the generic version.

Bad parenthesis nesting.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
include/asm-generic/mutex-dec.h
include/asm-i386/mutex.h
include/asm-x86_64/mutex.h

index 74b18cd..40c6d1f 100644 (file)
@@ -97,7 +97,7 @@ __mutex_fastpath_trylock(atomic_t *count, int (*fail_fn)(atomic_t *))
         * the mutex state would be.
         */
 #ifdef __HAVE_ARCH_CMPXCHG
-       if (likely(atomic_cmpxchg(count, 1, 0)) == 1) {
+       if (likely(atomic_cmpxchg(count, 1, 0) == 1)) {
                smp_mb();
                return 1;
        }
index c657d4b..9b2199e 100644 (file)
@@ -125,7 +125,7 @@ __mutex_fastpath_trylock(atomic_t *count, int (*fail_fn)(atomic_t *))
         * the mutex state would be.
         */
 #ifdef __HAVE_ARCH_CMPXCHG
-       if (likely(atomic_cmpxchg(count, 1, 0)) == 1)
+       if (likely(atomic_cmpxchg(count, 1, 0) == 1))
                return 1;
        return 0;
 #else
index 818abfd..11fbee2 100644 (file)
@@ -104,7 +104,7 @@ do {                                                                        \
 static inline int
 __mutex_fastpath_trylock(atomic_t *count, int (*fail_fn)(atomic_t *))
 {
-       if (likely(atomic_cmpxchg(count, 1, 0)) == 1)
+       if (likely(atomic_cmpxchg(count, 1, 0) == 1))
                return 1;
        else
                return 0;