OSDN Git Service

ASoC: wm8903: harmless underflow in wm8903_put_deemph()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 13 Oct 2015 07:10:18 +0000 (10:10 +0300)
committerMark Brown <broonie@kernel.org>
Thu, 22 Oct 2015 12:57:19 +0000 (13:57 +0100)
Valid values for "deemph" are zero and one, but we accidentally allow
negative values as well.  It's harmless, but static checkers complain
and we may as well clean it up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8903.c

index b011253..e4cc41e 100644 (file)
@@ -452,7 +452,7 @@ static int wm8903_put_deemph(struct snd_kcontrol *kcontrol,
 {
        struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
        struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
-       int deemph = ucontrol->value.integer.value[0];
+       unsigned int deemph = ucontrol->value.integer.value[0];
        int ret = 0;
 
        if (deemph > 1)