OSDN Git Service

hwrng: cctrn - Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 15:32:33 +0000 (17:32 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 4 Sep 2020 07:57:15 +0000 (17:57 +1000)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Hadar Gat <hadar.gat@arm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/cctrng.c

index 619148f..7a293f2 100644 (file)
@@ -463,11 +463,10 @@ static int cc_trng_clk_init(struct cctrng_drvdata *drvdata)
        int rc = 0;
 
        clk = devm_clk_get_optional(dev, NULL);
-       if (IS_ERR(clk)) {
-               if (PTR_ERR(clk) != -EPROBE_DEFER)
-                       dev_err(dev, "Error getting clock: %pe\n", clk);
-               return PTR_ERR(clk);
-       }
+       if (IS_ERR(clk))
+               return dev_err_probe(dev, PTR_ERR(clk),
+                                    "Error getting clock\n");
+
        drvdata->clk = clk;
 
        rc = clk_prepare_enable(drvdata->clk);