OSDN Git Service

net/mlx5: Remove redundant notify fail on give pages
authorMoshe Shemesh <moshe@nvidia.com>
Mon, 24 Jan 2022 09:43:45 +0000 (11:43 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 9 Mar 2022 21:33:01 +0000 (13:33 -0800)
If give pages command failed by FW, there is no need to notify the FW on
the failure. FW is aware and will handle it.

Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c

index f6b5451..de15064 100644 (file)
@@ -365,8 +365,12 @@ retry:
        MLX5_SET(manage_pages_in, in, input_num_entries, npages);
        MLX5_SET(manage_pages_in, in, embedded_cpu_function, ec_function);
 
-       err = mlx5_cmd_exec(dev, in, inlen, out, sizeof(out));
+       err = mlx5_cmd_do(dev, in, inlen, out, sizeof(out));
        if (err) {
+               if (err == -EREMOTEIO)
+                       notify_fail = 0;
+
+               err = mlx5_cmd_check(dev, err, in, out);
                mlx5_core_warn(dev, "func_id 0x%x, npages %d, err %d\n",
                               func_id, npages, err);
                goto out_4k;