OSDN Git Service

xenfb: use the correct condition to avoid excessive looping
authorWei Liu <wei.liu2@citrix.com>
Tue, 12 Apr 2016 10:43:14 +0000 (11:43 +0100)
committerStefano Stabellini <sstabellini@kernel.org>
Tue, 12 Apr 2016 17:16:08 +0000 (10:16 -0700)
In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <=
out_cons"), ">=" was used. In fact, a full ring is a legit state.
Correct the test to use ">".

Reported-by: "Hao, Xudong" <xudong.hao@intel.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Tested-by: "Hao, Xudong" <xudong.hao@intel.com>
Acked-by: Anthony Perard <anthony.perard@citrix.com>
Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
hw/display/xenfb.c

index 40b096a..9866dfd 100644 (file)
@@ -775,7 +775,7 @@ static void xenfb_handle_events(struct XenFB *xenfb)
 
     prod = page->out_prod;
     out_cons = page->out_cons;
-    if (prod - out_cons >= XENFB_OUT_RING_LEN) {
+    if (prod - out_cons > XENFB_OUT_RING_LEN) {
         return;
     }
     xen_rmb();         /* ensure we see ring contents up to prod */