OSDN Git Service

anv/batch_chain: free pointers for error cases
authorMark Janes <mark.a.janes@intel.com>
Wed, 18 May 2016 21:28:38 +0000 (14:28 -0700)
committerMark Janes <mark.a.janes@intel.com>
Wed, 18 May 2016 22:14:22 +0000 (15:14 -0700)
Trivial fix to improperly handled cleanup during
VK_ERROR_OUT_OF_HOST_MEMORY.

Identified by Coverity: CID 1358908 and 1358909
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
src/intel/vulkan/anv_batch_chain.c

index 36c9565..a98a0a9 100644 (file)
@@ -120,7 +120,7 @@ anv_reloc_list_grow(struct anv_reloc_list *list,
    struct anv_bo **new_reloc_bos =
       anv_alloc(alloc, new_length * sizeof(*list->reloc_bos), 8,
                 VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
-   if (new_relocs == NULL) {
+   if (new_reloc_bos == NULL) {
       anv_free(alloc, new_relocs);
       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
    }
@@ -891,7 +891,7 @@ anv_cmd_buffer_add_bo(struct anv_cmd_buffer *cmd_buffer,
          struct anv_bo **new_bos =
             anv_alloc(&cmd_buffer->pool->alloc, new_len * sizeof(*new_bos),
                       8, VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
-         if (new_objects == NULL) {
+         if (new_bos == NULL) {
             anv_free(&cmd_buffer->pool->alloc, new_objects);
             return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
          }