OSDN Git Service

Input: db9 - mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 11 Feb 2019 22:48:04 +0000 (14:48 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sun, 17 Feb 2019 05:39:42 +0000 (21:39 -0800)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/input/joystick/db9.c: In function ‘db9_saturn_read_packet’:
drivers/input/joystick/db9.c:256:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (tmp == 0xff) {
      ^
drivers/input/joystick/db9.c:263:2: note: here
  default:
  ^~~~~~~

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/db9.c

index 804b1b8..5a52b65 100644 (file)
@@ -259,7 +259,7 @@ static unsigned char db9_saturn_read_packet(struct parport *port, unsigned char
                        db9_saturn_write_sub(port, type, 3, powered, 0);
                        return data[0] = 0xe3;
                }
-               /* else: fall through */
+               /* fall through */
        default:
                return data[0];
        }