OSDN Git Service

ASoC: qcom: Remove duplicate error messages on ioremap
authorStephen Boyd <swboyd@chromium.org>
Fri, 15 Jan 2021 03:43:27 +0000 (19:43 -0800)
committerMark Brown <broonie@kernel.org>
Fri, 15 Jan 2021 14:14:43 +0000 (14:14 +0000)
We don't need to print an error message when these ioremap operations
fail. The function that returns an error already prints an error message
and properly attributes it to the device. Drop them to save some code.

Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Cc: Srinivasa Rao <srivasam@codeaurora.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Cheng-Yi Chiang <cychiang@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210115034327.617223-5-swboyd@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/lpass-cpu.c

index b267fe8..0ca957d 100644 (file)
@@ -788,11 +788,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev)
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif");
 
        drvdata->lpaif = devm_ioremap_resource(dev, res);
-       if (IS_ERR(drvdata->lpaif)) {
-               dev_err(dev, "error mapping reg resource: %ld\n",
-                               PTR_ERR(drvdata->lpaif));
+       if (IS_ERR(drvdata->lpaif))
                return PTR_ERR(drvdata->lpaif);
-       }
 
        lpass_cpu_regmap_config.max_register = LPAIF_WRDMAPER_REG(variant,
                                                variant->wrdma_channels +
@@ -810,11 +807,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev)
                res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-hdmiif");
 
                drvdata->hdmiif = devm_ioremap_resource(dev, res);
-               if (IS_ERR(drvdata->hdmiif)) {
-                       dev_err(dev, "error mapping reg resource: %ld\n",
-                                       PTR_ERR(drvdata->hdmiif));
+               if (IS_ERR(drvdata->hdmiif))
                        return PTR_ERR(drvdata->hdmiif);
-               }
 
                lpass_hdmi_regmap_config.max_register = LPAIF_HDMI_RDMAPER_REG(variant,
                                        variant->hdmi_rdma_channels);