OSDN Git Service

usb: cdns3: gadget: improve the dump TRB operation at cdns3_ep_run_transfer
authorPeter Chen <peter.chen@nxp.com>
Thu, 10 Sep 2020 09:11:24 +0000 (17:11 +0800)
committerFelipe Balbi <balbi@kernel.org>
Fri, 2 Oct 2020 06:57:45 +0000 (09:57 +0300)
It only dumps the first TRB per request, it is not useful if only dump
the first TRB when there are several TRBs per request. We improve it by
dumpping all TRBs per request in this commit.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/cdns3/gadget.c

index caf011f..d33947d 100644 (file)
@@ -1090,6 +1090,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
        struct cdns3_device *priv_dev = priv_ep->cdns3_dev;
        struct cdns3_request *priv_req;
        struct cdns3_trb *trb;
+       struct cdns3_trb *link_trb;
        dma_addr_t trb_dma;
        u32 togle_pcs = 1;
        int sg_iter = 0;
@@ -1130,7 +1131,6 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
 
        /* prepare ring */
        if ((priv_ep->enqueue + num_trb)  >= (priv_ep->num_trbs - 1)) {
-               struct cdns3_trb *link_trb;
                int doorbell, dma_index;
                u32 ch_bit = 0;
 
@@ -1266,7 +1266,22 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
        if (priv_dev->dev_ver <= DEV_VER_V2)
                cdns3_wa1_tray_restore_cycle_bit(priv_dev, priv_ep);
 
-       trace_cdns3_prepare_trb(priv_ep, priv_req->trb);
+       if (num_trb > 1) {
+               int i = 0;
+
+               while (i < num_trb) {
+                       trace_cdns3_prepare_trb(priv_ep, trb + i);
+                       if (trb + i == link_trb) {
+                               trb = priv_ep->trb_pool;
+                               num_trb = num_trb - i;
+                               i = 0;
+                       } else {
+                               i++;
+                       }
+               }
+       } else {
+               trace_cdns3_prepare_trb(priv_ep, priv_req->trb);
+       }
 
        /*
         * Memory barrier - Cycle Bit must be set before trb->length  and