OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
544c55c
)
ASoC: Intel: Delete an unnecessary check before the function call "release_firmware"
author
Markus Elfring
<elfring@users.sourceforge.net>
Sat, 3 Jan 2015 18:49:37 +0000
(19:49 +0100)
committer
Mark Brown
<broonie@kernel.org>
Mon, 5 Jan 2015 19:03:34 +0000
(19:03 +0000)
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/sst/sst_loader.c
patch
|
blob
|
history
diff --git
a/sound/soc/intel/sst/sst_loader.c
b/sound/soc/intel/sst/sst_loader.c
index
b580f96
..
7888cd7
100644
(file)
--- a/
sound/soc/intel/sst/sst_loader.c
+++ b/
sound/soc/intel/sst/sst_loader.c
@@
-324,8
+324,7
@@
void sst_firmware_load_cb(const struct firmware *fw, void *context)
if (ctx->sst_state != SST_RESET ||
ctx->fw_in_mem != NULL) {
- if (fw != NULL)
- release_firmware(fw);
+ release_firmware(fw);
mutex_unlock(&ctx->sst_lock);
return;
}