OSDN Git Service

Clean up read barrier related comments in Optimizing.
authorRoland Levillain <rpl@google.com>
Mon, 23 Nov 2015 19:29:22 +0000 (19:29 +0000)
committerRoland Levillain <rpl@google.com>
Mon, 23 Nov 2015 19:29:22 +0000 (19:29 +0000)
Bug: 12687968
Change-Id: Idf2e371e01e10d9d32c95b150735e2c96244232e

compiler/optimizing/code_generator_arm.cc
compiler/optimizing/code_generator_x86.cc
compiler/optimizing/code_generator_x86_64.cc

index cf6f7e3..461319e 100644 (file)
@@ -4330,7 +4330,7 @@ void LocationsBuilderARM::VisitArraySet(HArraySet* instruction) {
   if (needs_write_barrier) {
     // Temporary registers for the write barrier.
     locations->AddTemp(Location::RequiresRegister());  // Possibly used for ref. poisoning too.
-    locations->AddTemp(Location::RequiresRegister());  // Possibly used for read barrier too.
+    locations->AddTemp(Location::RequiresRegister());
   }
 }
 
index 53e33bf..6a9177d 100644 (file)
@@ -4854,7 +4854,7 @@ void LocationsBuilderX86::VisitArraySet(HArraySet* instruction) {
     // Temporary registers for the write barrier.
     locations->AddTemp(Location::RequiresRegister());  // Possibly used for ref. poisoning too.
     // Ensure the card is in a byte register.
-    locations->AddTemp(Location::RegisterLocation(ECX));  // Possibly used for read barrier too.
+    locations->AddTemp(Location::RegisterLocation(ECX));
   }
 }
 
index 0e0b869..8cfd8cb 100644 (file)
@@ -4496,8 +4496,6 @@ void LocationsBuilderX86_64::VisitArraySet(HArraySet* instruction) {
     // This first temporary register is possibly used for heap
     // reference poisoning and/or read barrier emission too.
     locations->AddTemp(Location::RequiresRegister());
-    // This second temporary register is possibly used for read
-    // barrier emission too.
     locations->AddTemp(Location::RequiresRegister());
   }
 }