OSDN Git Service

fm10k: reduce the scope of qv local variable
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 8 Jul 2019 23:12:20 +0000 (16:12 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 1 Aug 2019 21:09:39 +0000 (14:09 -0700)
Reduce the scope of the qv vector pointer local variable in the
fm10k_set_coalesce function.

This was detected by cppcheck and resolves the following style warning
produced by that tool:

[fm10k_ethtool.c:658]: (style) The scope of the variable 'qv' can be
reduced.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c

index 7b9440c..1f7e4a8 100644 (file)
@@ -650,7 +650,6 @@ static int fm10k_set_coalesce(struct net_device *dev,
                              struct ethtool_coalesce *ec)
 {
        struct fm10k_intfc *interface = netdev_priv(dev);
-       struct fm10k_q_vector *qv;
        u16 tx_itr, rx_itr;
        int i;
 
@@ -676,7 +675,8 @@ static int fm10k_set_coalesce(struct net_device *dev,
 
        /* update q_vectors */
        for (i = 0; i < interface->num_q_vectors; i++) {
-               qv = interface->q_vector[i];
+               struct fm10k_q_vector *qv = interface->q_vector[i];
+
                qv->tx.itr = tx_itr;
                qv->rx.itr = rx_itr;
        }