OSDN Git Service

drm/msm: Use struct fb_info.screen_buffer
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 22 May 2023 19:17:01 +0000 (21:17 +0200)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sun, 4 Jun 2023 01:58:22 +0000 (04:58 +0300)
The fbdev framebuffer is in system memory. Store the address in
the field 'screen_buffer'. Fixes the following sparse warning.

../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces)
../drivers/gpu/drm/msm/msm_fbdev.c:124:26:    expected char [noderef] __iomem *screen_base
../drivers/gpu/drm/msm/msm_fbdev.c:124:26:    got void *

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/538531/
Link: https://lore.kernel.org/r/20230522191701.13406-1-tzimmermann@suse.de
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/msm_fbdev.c

index 2ebc863..ce0ba6d 100644 (file)
@@ -121,9 +121,9 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
 
        drm_fb_helper_fill_info(fbi, helper, sizes);
 
-       fbi->screen_base = msm_gem_get_vaddr(bo);
-       if (IS_ERR(fbi->screen_base)) {
-               ret = PTR_ERR(fbi->screen_base);
+       fbi->screen_buffer = msm_gem_get_vaddr(bo);
+       if (IS_ERR(fbi->screen_buffer)) {
+               ret = PTR_ERR(fbi->screen_buffer);
                goto fail;
        }
        fbi->screen_size = bo->size;