OSDN Git Service

drm/msm: change msm_sched_ops from global to static
authorTom Rix <trix@redhat.com>
Thu, 21 Apr 2022 13:15:07 +0000 (09:15 -0400)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Wed, 27 Apr 2022 07:50:22 +0000 (10:50 +0300)
Smatch reports this issue
msm_ringbuffer.c:43:36: warning: symbol 'msm_sched_ops' was not declared. Should it be static?

msm_sched_ops is only used in msm_ringbuffer.c so change its
storage-class specifier to static.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/482883/
Link: https://lore.kernel.org/r/20220421131507.1557667-1-trix@redhat.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/msm_ringbuffer.c

index eb67fce..4306632 100644 (file)
@@ -51,7 +51,7 @@ static void msm_job_free(struct drm_sched_job *job)
        msm_gem_submit_put(submit);
 }
 
-const struct drm_sched_backend_ops msm_sched_ops = {
+static const struct drm_sched_backend_ops msm_sched_ops = {
        .run_job = msm_job_run,
        .free_job = msm_job_free
 };