OSDN Git Service

btrfs: Remove unused locking functions
authorNikolay Borisov <nborisov@suse.com>
Thu, 25 Jul 2019 08:27:28 +0000 (11:27 +0300)
committerDavid Sterba <dsterba@suse.com>
Mon, 9 Sep 2019 12:58:59 +0000 (14:58 +0200)
Those were split out of btrfs_clear_lock_blocking_rw by
aa12c02778a9 ("btrfs: split btrfs_clear_lock_blocking_rw to read and write helpers")
however at that time this function was unused due to commit
523983401644 ("Btrfs: kill btrfs_clear_path_blocking"). Put the final
nail in the coffin of those 2 functions.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/locking.c
fs/btrfs/locking.h
include/trace/events/btrfs.h

index 393eced..e4309bc 100644 (file)
@@ -119,42 +119,6 @@ void btrfs_set_lock_blocking_write(struct extent_buffer *eb)
        }
 }
 
-void btrfs_clear_lock_blocking_read(struct extent_buffer *eb)
-{
-       trace_btrfs_clear_lock_blocking_read(eb);
-       /*
-        * No lock is required.  The lock owner may change if we have a read
-        * lock, but it won't change to or away from us.  If we have the write
-        * lock, we are the owner and it'll never change.
-        */
-       if (eb->lock_nested && current->pid == eb->lock_owner)
-               return;
-       BUG_ON(atomic_read(&eb->blocking_readers) == 0);
-       read_lock(&eb->lock);
-       btrfs_assert_spinning_readers_get(eb);
-       /* atomic_dec_and_test implies a barrier */
-       if (atomic_dec_and_test(&eb->blocking_readers))
-               cond_wake_up_nomb(&eb->read_lock_wq);
-}
-
-void btrfs_clear_lock_blocking_write(struct extent_buffer *eb)
-{
-       trace_btrfs_clear_lock_blocking_write(eb);
-       /*
-        * no lock is required.  The lock owner may change if
-        * we have a read lock, but it won't change to or away
-        * from us.  If we have the write lock, we are the owner
-        * and it'll never change.
-        */
-       if (eb->lock_nested && current->pid == eb->lock_owner)
-               return;
-       write_lock(&eb->lock);
-       BUG_ON(eb->blocking_writers != 1);
-       btrfs_assert_spinning_writers_get(eb);
-       if (--eb->blocking_writers == 0)
-               cond_wake_up(&eb->write_lock_wq);
-}
-
 /*
  * take a spinning read lock.  This will wait for any blocking
  * writers
index 595014f..b775a42 100644 (file)
@@ -19,8 +19,6 @@ void btrfs_tree_read_unlock(struct extent_buffer *eb);
 void btrfs_tree_read_unlock_blocking(struct extent_buffer *eb);
 void btrfs_set_lock_blocking_read(struct extent_buffer *eb);
 void btrfs_set_lock_blocking_write(struct extent_buffer *eb);
-void btrfs_clear_lock_blocking_read(struct extent_buffer *eb);
-void btrfs_clear_lock_blocking_write(struct extent_buffer *eb);
 void btrfs_assert_tree_locked(struct extent_buffer *eb);
 int btrfs_try_tree_read_lock(struct extent_buffer *eb);
 int btrfs_try_tree_write_lock(struct extent_buffer *eb);
index 2f6a669..5cb9564 100644 (file)
@@ -2086,8 +2086,6 @@ DEFINE_BTRFS_LOCK_EVENT(btrfs_tree_read_unlock);
 DEFINE_BTRFS_LOCK_EVENT(btrfs_tree_read_unlock_blocking);
 DEFINE_BTRFS_LOCK_EVENT(btrfs_set_lock_blocking_read);
 DEFINE_BTRFS_LOCK_EVENT(btrfs_set_lock_blocking_write);
-DEFINE_BTRFS_LOCK_EVENT(btrfs_clear_lock_blocking_read);
-DEFINE_BTRFS_LOCK_EVENT(btrfs_clear_lock_blocking_write);
 DEFINE_BTRFS_LOCK_EVENT(btrfs_try_tree_read_lock);
 DEFINE_BTRFS_LOCK_EVENT(btrfs_try_tree_write_lock);
 DEFINE_BTRFS_LOCK_EVENT(btrfs_tree_read_lock_atomic);