OSDN Git Service

[media] v4l: s5p-tv: Use kcalloc instead of kzalloc to allocate array
authorThomas Meyer <thomas@m3y3r.de>
Tue, 29 Nov 2011 20:08:00 +0000 (17:08 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 30 Dec 2011 19:22:08 +0000 (17:22 -0200)
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/s5p-tv/hdmi_drv.c

index 0279e6e..8199288 100644 (file)
@@ -838,8 +838,8 @@ static int hdmi_resources_init(struct hdmi_device *hdev)
                dev_err(dev, "failed to get clock 'hdmiphy'\n");
                goto fail;
        }
-       res->regul_bulk = kzalloc(ARRAY_SIZE(supply) *
-               sizeof res->regul_bulk[0], GFP_KERNEL);
+       res->regul_bulk = kcalloc(ARRAY_SIZE(supply),
+                                 sizeof(res->regul_bulk[0]), GFP_KERNEL);
        if (!res->regul_bulk) {
                dev_err(dev, "failed to get memory for regulators\n");
                goto fail;