OSDN Git Service

i965: Add a note about a bug from the no-recompile-on-sampler-updates change.
authorEric Anholt <eric@anholt.net>
Tue, 20 Nov 2012 22:28:48 +0000 (14:28 -0800)
committerEric Anholt <eric@anholt.net>
Fri, 28 Dec 2012 18:53:25 +0000 (10:53 -0800)
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp

index 8967a6c..4bde6c7 100644 (file)
@@ -1295,6 +1295,10 @@ fs_visitor::visit(ir_texture *ir)
    fs_inst *inst = NULL;
 
    int sampler = _mesa_get_sampler_uniform_value(ir->sampler, prog, &fp->Base);
+   /* FINISHME: We're failing to recompile our programs when the sampler is
+    * updated.  This only matters for the texture rectangle scale parameters
+    * (pre-gen6, or gen6+ with GL_CLAMP).
+    */
    int texunit = fp->Base.SamplerUnits[sampler];
 
    /* Should be lowered by do_lower_texture_projection */