OSDN Git Service

net/chelsio: Don't set N/A for not available FW
authorLeon Romanovsky <leonro@mellanox.com>
Sun, 1 Mar 2020 14:44:42 +0000 (16:44 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Mar 2020 01:54:54 +0000 (17:54 -0800)
There is no need to set N/A if FW is not available.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c

index f3acdce..2cf3569 100644 (file)
@@ -174,9 +174,7 @@ static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
                sizeof(info->bus_info));
        info->regdump_len = get_regs_len(dev);
 
-       if (!adapter->params.fw_vers)
-               strcpy(info->fw_version, "N/A");
-       else
+       if (adapter->params.fw_vers)
                snprintf(info->fw_version, sizeof(info->fw_version),
                         "%u.%u.%u.%u, TP %u.%u.%u.%u",
                         FW_HDR_FW_VER_MAJOR_G(adapter->params.fw_vers),