OSDN Git Service

PCI: endpoint: Return -EINVAL when interrupts num is smaller than 1
authorLi Chen <lchen@ambarella.com>
Tue, 21 Dec 2021 02:59:56 +0000 (02:59 +0000)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Fri, 7 Jan 2022 10:35:34 +0000 (10:35 +0000)
In pci_epc_set_msi() we should return immediately if there are no
interrupts to configure; update the code to return early.

Link: https://lore.kernel.org/r/CH2PR19MB402491B9E503694DBCAC6005A07C9@CH2PR19MB4024.namprd19.prod.outlook.com
Signed-off-by: Li Chen <lchen@ambarella.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/pci/endpoint/pci-epc-core.c

index 3862155..3bc9273 100644 (file)
@@ -334,7 +334,7 @@ int pci_epc_set_msi(struct pci_epc *epc, u8 func_no, u8 vfunc_no, u8 interrupts)
        u8 encode_int;
 
        if (IS_ERR_OR_NULL(epc) || func_no >= epc->max_functions ||
-           interrupts > 32)
+           interrupts < 1 || interrupts > 32)
                return -EINVAL;
 
        if (vfunc_no > 0 && (!epc->max_vfs || vfunc_no > epc->max_vfs[func_no]))