OSDN Git Service

iio: orientation: hid-sensor-rotation: Drop unnecessary static
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 15 Jul 2017 20:07:44 +0000 (22:07 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 17 Jul 2017 20:45:01 +0000 (21:45 +0100)
Drop static on a local variable, when the variable is initialized before
any possible use.  Thus, the static has no benefit.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/orientation/hid-sensor-rotation.c

index e9fa86c..98fe0c5 100644 (file)
@@ -238,7 +238,7 @@ static int dev_rot_parse_report(struct platform_device *pdev,
 static int hid_dev_rot_probe(struct platform_device *pdev)
 {
        int ret;
-       static char *name;
+       char *name;
        struct iio_dev *indio_dev;
        struct dev_rot_state *rot_state;
        struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;