OSDN Git Service

net: bcmgenet: remove netif_carrier_off from adjust_link
authorDoug Berger <opendmb@gmail.com>
Sun, 26 Sep 2021 03:21:11 +0000 (20:21 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Sep 2021 15:34:51 +0000 (16:34 +0100)
The bcmgenet_mii_setup() function is registered as the adjust_link
callback from the phylib for the GENET driver.

The phylib always sets the netif_carrier according to phydev->link
prior to invoking the adjust_link callback, so there is no need to
repeat that in the link down case within the network driver.

Signed-off-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/genet/bcmmii.c

index ff1efd5..8a9d8ce 100644 (file)
@@ -106,9 +106,6 @@ void bcmgenet_mii_setup(struct net_device *dev)
                /* done if nothing has changed */
                if (!status_changed)
                        return;
-
-               /* needed for MoCA fixed PHY to reflect correct link status */
-               netif_carrier_off(dev);
        }
 
        phy_print_status(phydev);