* spawn.cc (spawn_guts): Fix potential handle leak when failing exec.

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index 1fd67e5..1cb69b9 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,5 +1,9 @@
 2006-01-27  Christopher Faylor  <cgf@timesys.com>
 
+       * spawn.cc (spawn_guts): Fix potential handle leak when failing exec.
+
+2006-01-27  Christopher Faylor  <cgf@timesys.com>
+
        * exceptions.cc (inside_kernel): Fix to return true if we can't get the
        name of the DLL for the given memory block since we are not in kernel
        code.

diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index 4e5982c..8edbf55 100644 (file)
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -731,7 +731,8 @@ spawn_guts (const char * prog_arg, const char *const *argv,
          myself->exec_sendsig = NULL;
        }
       res = -1;
-      CloseHandle (moreinfo->myself_pinfo);
+      if (moreinfo->myself_pinfo)
+       CloseHandle (moreinfo->myself_pinfo);
       goto out;
     }