OSDN Git Service

Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().
authorSam Muhammed <jane.pnx9@gmail.com>
Wed, 25 Mar 2020 14:26:37 +0000 (10:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Mar 2020 18:38:39 +0000 (19:38 +0100)
kzalloc(sizeof(*var), ...) was the format been used
across the driver, which is the preferred format,
but missed two instances, correct them to match the
coding standards.

Checkpatch.pl CHECK: Prefer kzalloc(sizeof(*var)...)
over kzalloc(sizeof(struct var)...)

Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Link: https://lore.kernel.org/r/bbb3adbd20ae89db6a0d3360bc09d22eed778e86.1585143581.git.jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc_dma/fileops.c
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c

index 5eb6c5f..21ebab7 100644 (file)
@@ -253,7 +253,7 @@ int  kpc_dma_open(struct inode *inode, struct file *filp)
                return -EBUSY; /* already open */
        }
 
-       priv = kzalloc(sizeof(struct dev_private_data), GFP_KERNEL);
+       priv = kzalloc(sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
index ec79a85..25ea16a 100644 (file)
@@ -98,7 +98,7 @@ int  kpc_dma_probe(struct platform_device *pldev)
        int rv = 0;
        dev_t dev;
 
-       struct kpc_dma_device *ldev = kzalloc(sizeof(struct kpc_dma_device), GFP_KERNEL);
+       struct kpc_dma_device *ldev = kzalloc(sizeof(*ldev), GFP_KERNEL);
 
        if (!ldev) {
                dev_err(&pldev->dev, "%s: unable to kzalloc space for kpc_dma_device\n", __func__);