OSDN Git Service

decnet: dn_dev: Remove an unnecessary label.
authorSuraj Upadhyay <usuraj35@gmail.com>
Tue, 14 Jul 2020 14:23:28 +0000 (19:53 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 16 Jul 2020 01:03:28 +0000 (18:03 -0700)
Remove the unnecessary label from dn_dev_ioctl() and make its error
handling simpler to read.

Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/decnet/dn_dev.c

index 65abcf1..15d4235 100644 (file)
@@ -462,7 +462,9 @@ int dn_dev_ioctl(unsigned int cmd, void __user *arg)
        switch (cmd) {
        case SIOCGIFADDR:
                *((__le16 *)sdn->sdn_nodeaddr) = ifa->ifa_local;
-               goto rarok;
+               if (copy_to_user(arg, ifr, DN_IFREQ_SIZE))
+                       ret = -EFAULT;
+               break;
 
        case SIOCSIFADDR:
                if (!ifa) {
@@ -485,10 +487,6 @@ done:
        rtnl_unlock();
 
        return ret;
-rarok:
-       if (copy_to_user(arg, ifr, DN_IFREQ_SIZE))
-               ret = -EFAULT;
-       goto done;
 }
 
 struct net_device *dn_dev_get_default(void)