import android.app.AlertDialog;
import android.app.Dialog;
-import android.content.ContentUris;
import android.content.ContentValues;
import android.content.Context;
import android.content.Intent;
-import android.content.res.Resources;
import android.database.Cursor;
import android.net.Uri;
import android.os.Bundle;
import com.android.settings.core.instrumentation.InstrumentedDialogFragment;
import com.android.internal.telephony.PhoneConstants;
import com.android.internal.util.ArrayUtils;
+import com.android.settingslib.utils.ThreadUtils;
import java.util.Arrays;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
-import static android.app.Activity.RESULT_OK;
import static android.content.Context.TELEPHONY_SERVICE;
/**
- * TODO: After loading all changes, please move this to network package.
+ * TODO(b/77339683): After loading all changes, please move this to network package.
*/
public class ApnEditor extends SettingsPreferenceFragment
implements OnPreferenceChangeListener, OnKeyListener {
private final static String TAG = ApnEditor.class.getSimpleName();
private final static boolean VDBG = false; // STOPSHIP if true
- private final static String SAVED_POS = "pos";
private final static String KEY_AUTH_TYPE = "auth_type";
private final static String KEY_PROTOCOL = "apn_protocol";
private final static String KEY_ROAMING_PROTOCOL = "apn_roaming_protocol";
private static final int MENU_SAVE = Menu.FIRST + 1;
private static final int MENU_CANCEL = Menu.FIRST + 2;
- private static String sNotSet;
- private EditTextPreference mName;
- private EditTextPreference mApn;
- private EditTextPreference mProxy;
- private EditTextPreference mPort;
- private EditTextPreference mUser;
- private EditTextPreference mServer;
- private EditTextPreference mPassword;
- private EditTextPreference mMmsc;
- private EditTextPreference mMcc;
- private EditTextPreference mMnc;
- private EditTextPreference mMmsProxy;
- private EditTextPreference mMmsPort;
- private ListPreference mAuthType;
- private EditTextPreference mApnType;
- private ListPreference mProtocol;
- private ListPreference mRoamingProtocol;
- private SwitchPreference mCarrierEnabled;
- private MultiSelectListPreference mBearerMulti;
- private ListPreference mMvnoType;
- private EditTextPreference mMvnoMatchData;
+ @VisibleForTesting
+ static String sNotSet;
+ @VisibleForTesting
+ EditTextPreference mName;
+ @VisibleForTesting
+ EditTextPreference mApn;
+ @VisibleForTesting
+ EditTextPreference mProxy;
+ @VisibleForTesting
+ EditTextPreference mPort;
+ @VisibleForTesting
+ EditTextPreference mUser;
+ @VisibleForTesting
+ EditTextPreference mServer;
+ @VisibleForTesting
+ EditTextPreference mPassword;
+ @VisibleForTesting
+ EditTextPreference mMmsc;
+ @VisibleForTesting
+ EditTextPreference mMcc;
+ @VisibleForTesting
+ EditTextPreference mMnc;
+ @VisibleForTesting
+ EditTextPreference mMmsProxy;
+ @VisibleForTesting
+ EditTextPreference mMmsPort;
+ @VisibleForTesting
+ ListPreference mAuthType;
+ @VisibleForTesting
+ EditTextPreference mApnType;
+ @VisibleForTesting
+ ListPreference mProtocol;
+ @VisibleForTesting
+ ListPreference mRoamingProtocol;
+ @VisibleForTesting
+ SwitchPreference mCarrierEnabled;
+ @VisibleForTesting
+ MultiSelectListPreference mBearerMulti;
+ @VisibleForTesting
+ ListPreference mMvnoType;
+ @VisibleForTesting
+ EditTextPreference mMvnoMatchData;
+
+ @VisibleForTesting
+ ApnData mApnData;
private String mCurMnc;
private String mCurMcc;
- private Uri mUri;
- private Cursor mCursor;
private boolean mNewApn;
- private boolean mFirstTime;
private int mSubId;
- private Resources mRes;
private TelephonyManager mTelephonyManager;
private int mBearerInitialVal = 0;
private String mMvnoTypeStr;
private String[] mReadOnlyApnTypes;
private String[] mReadOnlyApnFields;
private boolean mReadOnlyApn;
+ private Uri mCarrierUri;
/**
* Standard projection for the interesting columns of a normal note.
};
private static final int ID_INDEX = 0;
- private static final int NAME_INDEX = 1;
- private static final int APN_INDEX = 2;
+ @VisibleForTesting
+ static final int NAME_INDEX = 1;
+ @VisibleForTesting
+ static final int APN_INDEX = 2;
private static final int PROXY_INDEX = 3;
private static final int PORT_INDEX = 4;
private static final int USER_INDEX = 5;
private static final int SERVER_INDEX = 6;
private static final int PASSWORD_INDEX = 7;
private static final int MMSC_INDEX = 8;
- private static final int MCC_INDEX = 9;
- private static final int MNC_INDEX = 10;
+ @VisibleForTesting
+ static final int MCC_INDEX = 9;
+ @VisibleForTesting
+ static final int MNC_INDEX = 10;
private static final int MMSPROXY_INDEX = 12;
private static final int MMSPORT_INDEX = 13;
private static final int AUTH_TYPE_INDEX = 14;
private static final int TYPE_INDEX = 15;
private static final int PROTOCOL_INDEX = 16;
- private static final int CARRIER_ENABLED_INDEX = 17;
+ @VisibleForTesting
+ static final int CARRIER_ENABLED_INDEX = 17;
private static final int BEARER_INDEX = 18;
private static final int BEARER_BITMASK_INDEX = 19;
private static final int ROAMING_PROTOCOL_INDEX = 20;
private static final int EDITED_INDEX = 23;
private static final int USER_EDITABLE_INDEX = 24;
-
@Override
public void onCreate(Bundle icicle) {
super.onCreate(icicle);
mMvnoType = (ListPreference) findPreference(KEY_MVNO_TYPE);
mMvnoMatchData = (EditTextPreference) findPreference("mvno_match_data");
- mRes = getResources();
-
final Intent intent = getIntent();
final String action = intent.getAction();
mSubId = intent.getIntExtra(ApnSettings.SUB_ID,
SubscriptionManager.INVALID_SUBSCRIPTION_ID);
- mFirstTime = icicle == null;
mReadOnlyApn = false;
mReadOnlyApnTypes = null;
mReadOnlyApnFields = null;
}
}
+ Uri uri = null;
if (action.equals(Intent.ACTION_EDIT)) {
- Uri uri = intent.getData();
+ uri = intent.getData();
if (!uri.isPathPrefixMatch(Telephony.Carriers.CONTENT_URI)) {
Log.e(TAG, "Edit request not for carrier table. Uri: " + uri);
finish();
return;
}
- mUri = uri;
} else if (action.equals(Intent.ACTION_INSERT)) {
- if (mFirstTime || icicle.getInt(SAVED_POS) == 0) {
- Uri uri = intent.getData();
- if (!uri.isPathPrefixMatch(Telephony.Carriers.CONTENT_URI)) {
- Log.e(TAG, "Insert request not for carrier table. Uri: " + uri);
- finish();
- return;
- }
- ContentValues contentValues = new ContentValues();
- contentValues.put(Telephony.Carriers.EDITED, Telephony.Carriers.USER_EDITED);
- mUri = getContentResolver().insert(uri, contentValues);
- } else {
- mUri = ContentUris.withAppendedId(Telephony.Carriers.CONTENT_URI,
- icicle.getInt(SAVED_POS));
+ mCarrierUri = intent.getData();
+ if (!mCarrierUri.isPathPrefixMatch(Telephony.Carriers.CONTENT_URI)) {
+ Log.e(TAG, "Insert request not for carrier table. Uri: " + mCarrierUri);
+ finish();
+ return;
}
mNewApn = true;
mMvnoTypeStr = intent.getStringExtra(ApnSettings.MVNO_TYPE);
mMvnoMatchDataStr = intent.getStringExtra(ApnSettings.MVNO_MATCH_DATA);
- // If we were unable to create a new note, then just finish
- // this activity. A RESULT_CANCELED will be sent back to the
- // original activity if they requested a result.
- if (mUri == null) {
- Log.w(TAG, "Failed to insert new telephony provider into "
- + getIntent().getData());
- finish();
- return;
- }
-
- // The new entry was created, so assume all will end well and
- // set the result to be returned.
- setResult(RESULT_OK, (new Intent()).setAction(mUri.toString()));
-
} else {
finish();
return;
}
- mCursor = getActivity().managedQuery(mUri, sProjection, null, null);
- mCursor.moveToFirst();
+ // Creates an ApnData to store the apn data temporary, so that we don't need the cursor to
+ // get the apn data. The uri is null if the action is ACTION_INSERT, that mean there is no
+ // record in the database, so create a empty ApnData to represent a empty row of database.
+ if (uri != null) {
+ mApnData = getApnDataFromUri(uri);
+ } else {
+ mApnData = new ApnData(sProjection.length);
+ }
mTelephonyManager = (TelephonyManager) getSystemService(TELEPHONY_SERVICE);
- Log.d(TAG, "onCreate: EDITED " + mCursor.getInt(EDITED_INDEX));
+ boolean isUserEdited = mApnData.getInteger(EDITED_INDEX, Telephony.Carriers.USER_EDITED)
+ == Telephony.Carriers.USER_EDITED;
+
+ Log.d(TAG, "onCreate: EDITED " + isUserEdited);
// if it's not a USER_EDITED apn, check if it's read-only
- if (mCursor.getInt(EDITED_INDEX) != Telephony.Carriers.USER_EDITED &&
- (mCursor.getInt(USER_EDITABLE_INDEX) == 0 ||
- apnTypesMatch(mReadOnlyApnTypes, mCursor.getString(TYPE_INDEX)))) {
+ if (!isUserEdited && (mApnData.getInteger(USER_EDITABLE_INDEX, 1) == 0
+ || apnTypesMatch(mReadOnlyApnTypes, mApnData.getString(TYPE_INDEX)))) {
Log.d(TAG, "onCreate: apnTypesMatch; read-only APN");
mReadOnlyApn = true;
disableAllFields();
getPreferenceScreen().getPreference(i).setOnPreferenceChangeListener(this);
}
- }
-
- @Override
- public void onActivityCreated(Bundle savedInstanceState) {
- super.onActivityCreated(savedInstanceState);
- fillUi();
+ fillUI(icicle == null);
}
/**
return MetricsEvent.APN_EDITOR;
}
- @Override
- public void onResume() {
- super.onResume();
-
- if (mUri == null && mNewApn) {
- // The URI could have been deleted when activity is paused,
- // therefore, it needs to be restored.
- ContentValues contentValues = new ContentValues();
- contentValues.put(Telephony.Carriers.EDITED, Telephony.Carriers.USER_EDITED);
- mUri = getContentResolver().insert(getIntent().getData(), contentValues);
- if (mUri == null) {
- Log.w(TAG, "Failed to insert new telephony provider into "
- + getIntent().getData());
- finish();
- return;
- }
- mCursor = getActivity().managedQuery(mUri, sProjection, null, null);
- mCursor.moveToFirst();
- }
-
- }
-
- @Override
- public void onPause() {
- super.onPause();
- }
-
- private void fillUi() {
- if (mFirstTime) {
- mFirstTime = false;
+ @VisibleForTesting
+ void fillUI(boolean firstTime) {
+ if (firstTime) {
// Fill in all the values from the db in both text editor and summary
- mName.setText(mCursor.getString(NAME_INDEX));
- mApn.setText(mCursor.getString(APN_INDEX));
- mProxy.setText(mCursor.getString(PROXY_INDEX));
- mPort.setText(mCursor.getString(PORT_INDEX));
- mUser.setText(mCursor.getString(USER_INDEX));
- mServer.setText(mCursor.getString(SERVER_INDEX));
- mPassword.setText(mCursor.getString(PASSWORD_INDEX));
- mMmsProxy.setText(mCursor.getString(MMSPROXY_INDEX));
- mMmsPort.setText(mCursor.getString(MMSPORT_INDEX));
- mMmsc.setText(mCursor.getString(MMSC_INDEX));
- mMcc.setText(mCursor.getString(MCC_INDEX));
- mMnc.setText(mCursor.getString(MNC_INDEX));
- mApnType.setText(mCursor.getString(TYPE_INDEX));
+ mName.setText(mApnData.getString(NAME_INDEX));
+ mApn.setText(mApnData.getString(APN_INDEX));
+ mProxy.setText(mApnData.getString(PROXY_INDEX));
+ mPort.setText(mApnData.getString(PORT_INDEX));
+ mUser.setText(mApnData.getString(USER_INDEX));
+ mServer.setText(mApnData.getString(SERVER_INDEX));
+ mPassword.setText(mApnData.getString(PASSWORD_INDEX));
+ mMmsProxy.setText(mApnData.getString(MMSPROXY_INDEX));
+ mMmsPort.setText(mApnData.getString(MMSPORT_INDEX));
+ mMmsc.setText(mApnData.getString(MMSC_INDEX));
+ mMcc.setText(mApnData.getString(MCC_INDEX));
+ mMnc.setText(mApnData.getString(MNC_INDEX));
+ mApnType.setText(mApnData.getString(TYPE_INDEX));
if (mNewApn) {
String numeric = mTelephonyManager.getSimOperator(mSubId);
// MCC is first 3 chars and then in 2 - 3 chars of MNC
mCurMcc = mcc;
}
}
- int authVal = mCursor.getInt(AUTH_TYPE_INDEX);
+ int authVal = mApnData.getInteger(AUTH_TYPE_INDEX, -1);
if (authVal != -1) {
mAuthType.setValueIndex(authVal);
} else {
mAuthType.setValue(null);
}
- mProtocol.setValue(mCursor.getString(PROTOCOL_INDEX));
- mRoamingProtocol.setValue(mCursor.getString(ROAMING_PROTOCOL_INDEX));
- mCarrierEnabled.setChecked(mCursor.getInt(CARRIER_ENABLED_INDEX)==1);
- mBearerInitialVal = mCursor.getInt(BEARER_INDEX);
+ mProtocol.setValue(mApnData.getString(PROTOCOL_INDEX));
+ mRoamingProtocol.setValue(mApnData.getString(ROAMING_PROTOCOL_INDEX));
+ mCarrierEnabled.setChecked(mApnData.getInteger(CARRIER_ENABLED_INDEX, 1) == 1);
+ mBearerInitialVal = mApnData.getInteger(BEARER_INDEX, 0);
HashSet<String> bearers = new HashSet<String>();
- int bearerBitmask = mCursor.getInt(BEARER_BITMASK_INDEX);
+ int bearerBitmask = mApnData.getInteger(BEARER_BITMASK_INDEX, 0);
if (bearerBitmask == 0) {
if (mBearerInitialVal == 0) {
bearers.add("" + 0);
}
mBearerMulti.setValues(bearers);
- mMvnoType.setValue(mCursor.getString(MVNO_TYPE_INDEX));
+ mMvnoType.setValue(mApnData.getString(MVNO_TYPE_INDEX));
mMvnoMatchData.setEnabled(false);
- mMvnoMatchData.setText(mCursor.getString(MVNO_MATCH_DATA_INDEX));
+ mMvnoMatchData.setText(mApnData.getString(MVNO_MATCH_DATA_INDEX));
if (mNewApn && mMvnoTypeStr != null && mMvnoMatchDataStr != null) {
mMvnoType.setValue(mMvnoTypeStr);
mMvnoMatchData.setText(mMvnoMatchDataStr);
int authValIndex = Integer.parseInt(authVal);
mAuthType.setValueIndex(authValIndex);
- String []values = mRes.getStringArray(R.array.apn_auth_entries);
+ String[] values = getResources().getStringArray(R.array.apn_auth_entries);
mAuthType.setSummary(values[authValIndex]);
} else {
mAuthType.setSummary(sNotSet);
if (protocolIndex == -1) {
return null;
} else {
- String[] values = mRes.getStringArray(R.array.apn_protocol_entries);
+ String[] values = getResources().getStringArray(R.array.apn_protocol_entries);
try {
return values[protocolIndex];
} catch (ArrayIndexOutOfBoundsException e) {
if (mBearerIndex == -1) {
return null;
} else {
- String[] values = mRes.getStringArray(R.array.bearer_entries);
+ String[] values = getResources().getStringArray(R.array.bearer_entries);
try {
return values[mBearerIndex];
} catch (ArrayIndexOutOfBoundsException e) {
}
private String bearerMultiDescription(Set<String> raw) {
- String[] values = mRes.getStringArray(R.array.bearer_entries);
+ String[] values = getResources().getStringArray(R.array.bearer_entries);
StringBuilder retVal = new StringBuilder();
boolean first = true;
for (String bearer : raw) {
if (mvnoIndex == -1) {
return null;
} else {
- String[] values = mRes.getStringArray(R.array.mvno_type_entries);
+ String[] values = getResources().getStringArray(R.array.mvno_type_entries);
boolean mvnoMatchDataUneditable =
mReadOnlyApn || (mReadOnlyApnFields != null
&& Arrays.asList(mReadOnlyApnFields)
int index = Integer.parseInt((String) newValue);
mAuthType.setValueIndex(index);
- String[] values = mRes.getStringArray(R.array.apn_auth_entries);
+ String[] values = getResources().getStringArray(R.array.apn_auth_entries);
mAuthType.setSummary(values[index]);
} catch (NumberFormatException e) {
return false;
@Override
public boolean onOptionsItemSelected(MenuItem item) {
switch (item.getItemId()) {
- case MENU_DELETE:
- deleteApn();
- return true;
- case MENU_SAVE:
- if (validateAndSave(false)) {
+ case MENU_DELETE:
+ deleteApn();
finish();
- }
- return true;
- case MENU_CANCEL:
- if (mNewApn) {
- getContentResolver().delete(mUri, null, null);
- }
- finish();
- return true;
+ return true;
+ case MENU_SAVE:
+ if (validateAndSaveApnData()) {
+ finish();
+ }
+ return true;
+ case MENU_CANCEL:
+ finish();
+ return true;
+ default:
+ return super.onOptionsItemSelected(item);
}
- return super.onOptionsItemSelected(item);
}
@Override
view.requestFocus();
}
+ /**
+ * Try to save the apn data when pressed the back button. An error message will be displayed if
+ * the apn data is invalid.
+ *
+ * TODO(b/77339593): Try to keep the same behavior between back button and up navigate button.
+ * We will save the valid apn data to the database when pressed the back button, but discard all
+ * user changed when pressed the up navigate button.
+ */
+ @Override
public boolean onKey(View v, int keyCode, KeyEvent event) {
if (event.getAction() != KeyEvent.ACTION_DOWN) return false;
switch (keyCode) {
case KeyEvent.KEYCODE_BACK: {
- if (validateAndSave(false)) {
+ if (validateAndSaveApnData()) {
finish();
}
return true;
return false;
}
- @Override
- public void onSaveInstanceState(Bundle icicle) {
- super.onSaveInstanceState(icicle);
- if (validateAndSave(true)) {
- icicle.putInt(SAVED_POS, mCursor.getInt(ID_INDEX));
- }
- }
-
/**
- * Add key, value to cv and compare the value against the value at index in mCursor. Return true
- * if values are different. assumeDiff indicates if values can be assumed different in which
- * case no comparison is needed.
- * @return true if value is different from the value at index in mCursor
+ * Add key, value to {@code cv} and compare the value against the value at index in
+ * {@link #mApnData}.
+ *
+ * <p>
+ * The key, value will not add to {@code cv} if value is null.
+ *
+ * @return true if values are different. {@code assumeDiff} indicates if values can be assumed
+ * different in which case no comparison is needed.
*/
- boolean setStringValueAndCheckIfDiff(ContentValues cv, String key, String value,
- boolean assumeDiff, int index) {
- cv.put(key, value);
- String valueFromCursor = mCursor.getString(index);
+ boolean setStringValueAndCheckIfDiff(
+ ContentValues cv, String key, String value, boolean assumeDiff, int index) {
+ String valueFromLocalCache = mApnData.getString(index);
if (VDBG) {
Log.d(TAG, "setStringValueAndCheckIfDiff: assumeDiff: " + assumeDiff
+ " key: " + key
+ " value: '" + value
- + "' valueFromCursor: '" + valueFromCursor + "'");
+ + "' valueFromDb: '" + valueFromLocalCache + "'");
}
- return assumeDiff
- || !((TextUtils.isEmpty(value) && TextUtils.isEmpty(valueFromCursor))
- || (value != null && value.equals(valueFromCursor)));
+ boolean isDiff = assumeDiff
+ || !((TextUtils.isEmpty(value) && TextUtils.isEmpty(valueFromLocalCache))
+ || (value != null && value.equals(valueFromLocalCache)));
+
+ if (isDiff && value != null) {
+ cv.put(key, value);
+ }
+ return isDiff;
}
/**
- * Add key, value to cv and compare the value against the value at index in mCursor. Return true
- * if values are different. assumeDiff indicates if values can be assumed different in which
- * case no comparison is needed.
- * @return true if value is different from the value at index in mCursor
+ * Add key, value to {@code cv} and compare the value against the value at index in
+ * {@link #mApnData}.
+ *
+ * @return true if values are different. {@code assumeDiff} indicates if values can be assumed
+ * different in which case no comparison is needed.
*/
- boolean setIntValueAndCheckIfDiff(ContentValues cv, String key, int value,
- boolean assumeDiff, int index) {
- cv.put(key, value);
- int valueFromCursor = mCursor.getInt(index);
+ boolean setIntValueAndCheckIfDiff(
+ ContentValues cv, String key, int value, boolean assumeDiff, int index) {
+ Integer valueFromLocalCache = mApnData.getInteger(index);
if (VDBG) {
Log.d(TAG, "setIntValueAndCheckIfDiff: assumeDiff: " + assumeDiff
+ " key: " + key
+ " value: '" + value
- + "' valueFromCursor: '" + valueFromCursor + "'");
+ + "' valueFromDb: '" + valueFromLocalCache + "'");
+ }
+
+ boolean isDiff = assumeDiff || value != valueFromLocalCache;
+ if (isDiff) {
+ cv.put(key, value);
}
- return assumeDiff || value != valueFromCursor;
+ return isDiff;
}
/**
- * Check the key fields' validity and save if valid.
- * @param force save even if the fields are not valid, if the app is
- * being suspended
- * @return true if there's no error
+ * Validates the apn data and save it to the database if it's valid.
+ *
+ * <p>
+ * A dialog with error message will be displayed if the APN data is invalid.
+ *
+ * @return true if there is no error
*/
- private boolean validateAndSave(boolean force) {
- // nothing to do if it's a read only APN
+ @VisibleForTesting
+ boolean validateAndSaveApnData() {
+ // Nothing to do if it's a read only APN
if (mReadOnlyApn) {
return true;
}
String mcc = checkNotSet(mMcc.getText());
String mnc = checkNotSet(mMnc.getText());
- if (getErrorMsg() != null && !force) {
- ErrorDialog.showError(this);
- return false;
- }
-
- if (!mCursor.moveToFirst()) {
- Log.w(TAG,
- "Could not go to the first row in the Cursor when saving data.");
- return false;
- }
-
- // If it's a new APN and a name or apn haven't been entered, then erase the entry
- if (force && mNewApn && name.length() < 1 && apn.length() < 1) {
- getContentResolver().delete(mUri, null, null);
- mUri = null;
+ String errorMsg = validateApnData();
+ if (errorMsg != null) {
+ showError();
return false;
}
// call update() if it's a new APN. If not, check if any field differs from the db value;
// if any diff is found update() should be called
boolean callUpdate = mNewApn;
-
- // Add a dummy name "Untitled", if the user exits the screen without adding a name but
- // entered other information worth keeping.
callUpdate = setStringValueAndCheckIfDiff(values,
Telephony.Carriers.NAME,
- name.length() < 1 ? getResources().getString(R.string.untitled_apn) : name,
+ name,
callUpdate,
NAME_INDEX);
values.put(Telephony.Carriers.EDITED, Telephony.Carriers.USER_EDITED);
if (callUpdate) {
- getContentResolver().update(mUri, values, null, null);
+ final Uri uri = mApnData.getUri() == null ? mCarrierUri : mApnData.getUri();
+ updateApnDataToDatabase(uri, values);
} else {
- if (VDBG) Log.d(TAG, "validateAndSave: not calling update()");
+ if (VDBG) Log.d(TAG, "validateAndSaveApnData: not calling update()");
}
return true;
}
- private String getErrorMsg() {
+ private void updateApnDataToDatabase(Uri uri, ContentValues values) {
+ ThreadUtils.postOnBackgroundThread(() -> {
+ if (uri.equals(mCarrierUri)) {
+ // Add a new apn to the database
+ final Uri newUri = getContentResolver().insert(mCarrierUri, values);
+ if (newUri == null) {
+ Log.e(TAG, "Can't add a new apn to database " + mCarrierUri);
+ }
+ } else {
+ // Update the existing apn
+ getContentResolver().update(
+ uri, values, null /* where */, null /* selection Args */);
+ }
+ });
+ }
+
+ /**
+ * Validates whether the apn data is valid.
+ *
+ * @return An error message if the apn data is invalid, otherwise return null.
+ */
+ @VisibleForTesting
+ String validateApnData() {
String errorMsg = null;
String name = checkNotSet(mName.getText());
String mcc = checkNotSet(mMcc.getText());
String mnc = checkNotSet(mMnc.getText());
- if (name.length() < 1) {
- errorMsg = mRes.getString(R.string.error_name_empty);
- } else if (apn.length() < 1) {
- errorMsg = mRes.getString(R.string.error_apn_empty);
- } else if (mcc.length() != 3) {
- errorMsg = mRes.getString(R.string.error_mcc_not3);
- } else if ((mnc.length() & 0xFFFE) != 2) {
- errorMsg = mRes.getString(R.string.error_mnc_not23);
+ if (TextUtils.isEmpty(name)) {
+ errorMsg = getResources().getString(R.string.error_name_empty);
+ } else if (TextUtils.isEmpty(apn)) {
+ errorMsg = getResources().getString(R.string.error_apn_empty);
+ } else if (mcc == null || mcc.length() != 3) {
+ errorMsg = getResources().getString(R.string.error_mcc_not3);
+ } else if ((mnc == null || (mnc.length() & 0xFFFE) != 2)) {
+ errorMsg = getResources().getString(R.string.error_mnc_not23);
}
if (errorMsg == null) {
StringBuilder stringBuilder = new StringBuilder();
for (String type : mReadOnlyApnTypes) {
stringBuilder.append(type).append(", ");
- Log.d(TAG, "getErrorMsg: appending type: " + type);
+ Log.d(TAG, "validateApnData: appending type: " + type);
}
// remove last ", "
if (stringBuilder.length() >= 2) {
stringBuilder.delete(stringBuilder.length() - 2, stringBuilder.length());
}
- errorMsg = String.format(mRes.getString(R.string.error_adding_apn_type),
+ errorMsg = String.format(getResources().getString(R.string.error_adding_apn_type),
stringBuilder);
}
}
return errorMsg;
}
+ @VisibleForTesting
+ void showError() {
+ ErrorDialog.showError(this);
+ }
+
private void deleteApn() {
- getContentResolver().delete(mUri, null, null);
- finish();
+ if (mApnData.getUri() != null) {
+ getContentResolver().delete(mApnData.getUri(), null, null);
+ mApnData = new ApnData(sProjection.length);
+ }
}
private String starify(String value) {
}
}
+ /**
+ * Returns {@link #sNotSet} if the given string {@code value} is null or empty. The string
+ * {@link #sNotSet} typically used as the default display when an entry in the preference is
+ * null or empty.
+ */
private String checkNull(String value) {
- if (value == null || value.length() == 0) {
- return sNotSet;
- } else {
- return value;
- }
+ return TextUtils.isEmpty(value) ? sNotSet : value;
}
+ /**
+ * Returns null if the given string {@code value} equals to {@link #sNotSet}. This method
+ * should be used when convert a string value from preference to database.
+ */
private String checkNotSet(String value) {
- if (value == null || value.equals(sNotSet)) {
- return "";
- } else {
- return value;
- }
+ return sNotSet.equals(value) ? null : value;
}
private String getUserEnteredApnType() {
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
- String msg = ((ApnEditor) getTargetFragment()).getErrorMsg();
+ String msg = ((ApnEditor) getTargetFragment()).validateApnData();
return new AlertDialog.Builder(getContext())
.setTitle(R.string.error_title)
}
}
- public static class InvalidTypeException extends RuntimeException {
- InvalidTypeException(String msg) {
- super(msg);
+ private ApnData getApnDataFromUri(Uri uri) {
+ ApnData apnData;
+ try (Cursor cursor = getActivity().managedQuery(
+ uri, sProjection, null /* selection */, null /* sortOrder */)) {
+ cursor.moveToFirst();
+ apnData = new ApnData(uri, cursor);
+ }
+
+ if (apnData == null) {
+ Log.d(TAG, "Can't get apnData from Uri " + uri);
}
+
+ return apnData;
}
@VisibleForTesting
mUri = uri;
}
- Integer getInteger(int index) throws InvalidTypeException {
- if (!isValidTypeOrNull(mData[index], Integer.class)) {
- throwInvalidTypeException(Integer.class, mData[index].getClass());
- }
+ Integer getInteger(int index) {
return (Integer) mData[index];
}
- Integer getInteger(int index, Integer defaultValue) throws InvalidTypeException {
+ Integer getInteger(int index, Integer defaultValue) {
Integer val = getInteger(index);
return val == null ? defaultValue : val;
}
- String getString(int index) throws InvalidTypeException {
- if (!isValidTypeOrNull(mData[index], String.class)) {
- throwInvalidTypeException(String.class, mData[index].getClass());
- }
+ String getString(int index) {
return (String) mData[index];
}
-
- private boolean isValidTypeOrNull(Object obj, Class expectedClass) {
- return obj == null || expectedClass.isInstance(obj);
- }
-
- private void throwInvalidTypeException(Class<?> expectedClass, Class<?> actualClass) {
- throw new InvalidTypeException(
- String.format(
- "Type mismatched, want %s, but is %s", expectedClass, actualClass));
- }
}
-
}
package com.android.settings;
-import static junit.framework.Assert.assertEquals;
-import static junit.framework.Assert.assertNull;
+import static com.google.common.truth.Truth.assertThat;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.verify;
+import android.app.Activity;
+import android.content.ContentResolver;
+import android.content.ContentValues;
+import android.content.Context;
+import android.content.res.Resources;
import android.database.Cursor;
import android.net.Uri;
+import android.support.v14.preference.MultiSelectListPreference;
+import android.support.v14.preference.SwitchPreference;
+import android.support.v7.preference.EditTextPreference;
+import android.support.v7.preference.ListPreference;
+import android.view.KeyEvent;
+import android.view.Menu;
+import android.view.MenuItem;
+import android.view.View;
import com.android.settings.ApnEditor.ApnData;
-import com.android.settings.ApnEditor.InvalidTypeException;
import com.android.settings.testutils.SettingsRobolectricTestRunner;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Captor;
import org.mockito.Mock;
+import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
+import org.robolectric.Robolectric;
+import org.robolectric.RuntimeEnvironment;
@RunWith(SettingsRobolectricTestRunner.class)
public class ApnEditorTest {
+ private static final Object[] APN_DATA = new Object[] {
+ 0, /* ID */
+ "apn_name" /* apn name */,
+ "apn.com" /* apn */,
+ "" /* proxy */,
+ "" /* port */,
+ "" /* username */,
+ "" /* server */,
+ "" /* password */,
+ "" /* MMSC */,
+ "123" /* MCC */,
+ "456" /* MNC */,
+ "123456" /* operator numeric */,
+ "" /* MMS proxy */,
+ "" /* MMS port */,
+ 0 /* Authentication type */,
+ "default,supl,ia" /* APN type */,
+ "IPv6" /* APN protocol */,
+ 1 /* APN enable/disable */,
+ 0 /* Bearer */,
+ 0 /* Bearer BITMASK*/,
+ "IPv4" /* APN roaming protocol */,
+ "None" /* MVNO type */,
+ "", /* MVNO value */
+ };
+
private static final int CURSOR_INTEGER_INDEX = 0;
private static final int CURSOR_STRING_INDEX = 1;
@Mock
private Cursor mCursor;
+ @Captor
+ private ArgumentCaptor<Uri> mUriCaptor;
+
+ private ApnEditor mApnEditorUT;
+ private Activity mActivity;
+ private Resources mResources;
+
@Before
public void setUp() {
MockitoAnnotations.initMocks(this);
- initCursor();
+ mActivity = spy(Robolectric.setupActivity(Activity.class));
+ mResources = mActivity.getResources();
+ mApnEditorUT = spy(new ApnEditor());
+
+ doReturn(mActivity).when(mApnEditorUT).getActivity();
+ doReturn(mResources).when(mApnEditorUT).getResources();
+ doNothing().when(mApnEditorUT).finish();
+ doNothing().when(mApnEditorUT).showError();
+
+ setMockPreference(mActivity);
+ mApnEditorUT.mApnData = new FakeApnData(APN_DATA);
+ mApnEditorUT.sNotSet = "Not Set";
}
- private void initCursor() {
- doReturn(2).when(mCursor).getColumnCount();
- doReturn(Integer.valueOf(2)).when(mCursor).getInt(CURSOR_INTEGER_INDEX);
- doReturn("str").when(mCursor).getString(CURSOR_STRING_INDEX);
- doReturn(Cursor.FIELD_TYPE_INTEGER).when(mCursor).getType(CURSOR_INTEGER_INDEX);
- doReturn(Cursor.FIELD_TYPE_STRING).when(mCursor).getType(CURSOR_STRING_INDEX);
+ @Test
+ public void testSetStringValue_valueChanged_shouldSetValue() {
+ // GIVEN an APN value which is different than the APN value in database
+ final String apnKey = "apn";
+ final String apnValue = "testing.com";
+ final ContentValues cv = new ContentValues();
+
+ // WHEN try to check and set the apn value
+ final boolean isDiff = mApnEditorUT.setStringValueAndCheckIfDiff(
+ cv, apnKey, apnValue, false /* assumeDiff */, ApnEditor.APN_INDEX);
+
+ // THEN the APN value is different than the one in database, and it has been stored in the
+ // given ContentValues
+ assertThat(isDiff).isTrue();
+ assertThat(apnValue).isEqualTo(cv.getAsString(apnKey));
+ }
+
+ @Test
+ public void testSetStringValue_valueNotChanged_shouldNotSetValue() {
+ // GIVEN an APN value which is same as the APN value in database
+ final String apnKey = "apn";
+ final String apnValue = (String) APN_DATA[ApnEditor.APN_INDEX];
+ final ContentValues cv = new ContentValues();
+
+ // WHEN try to check and set the apn value
+ final boolean isDiff = mApnEditorUT.setStringValueAndCheckIfDiff(
+ cv, apnKey, apnValue, false /* assumeDiff */, ApnEditor.APN_INDEX);
+
+ // THEN the APN value is same as the one in database, and the new APN value is not stored
+ // in the given ContentValues
+ assertThat(isDiff).isFalse();
+ assertThat(cv.get(apnKey)).isNull();
+ }
+
+ @Test
+ public void testSetStringValue_nullValue_shouldNotSetValue_shouldNotSetValue() {
+ // GIVEN a null APN value
+ final String apnKey = "apn";
+ final String apnValue = null;
+ final ContentValues cv = new ContentValues();
+
+ // WHEN try to check and set the apn value
+ final boolean isDiff = mApnEditorUT.setStringValueAndCheckIfDiff(
+ cv, apnKey, apnValue, false /* assumeDiff */, ApnEditor.APN_INDEX);
+
+ // THEN the APN value is different than the one in database, but the null value is not
+ // stored in the given ContentValues
+ assertThat(isDiff).isTrue();
+ assertThat(cv.get(apnKey)).isNull();
}
- @Test(expected = InvalidTypeException.class)
+ @Test
+ public void testSetIntValue_valueChanged_shouldSetValue() {
+ // GIVEN a value indicated whether the apn is enabled, and it's different than the value in
+ // the database
+ final String apnEnabledKey = "apn_enabled";
+ final int apnEnabledValue = 0;
+ final ContentValues cv = new ContentValues();
+
+ // WHEN try to check and set the apn enabled
+ final boolean isDiff = mApnEditorUT.setIntValueAndCheckIfDiff(
+ cv,
+ apnEnabledKey,
+ apnEnabledValue,
+ false /* assumeDiff */,
+ ApnEditor.CARRIER_ENABLED_INDEX);
+
+ // THEN the apn enabled field is different than the one in database, and it has been stored
+ // in the given ContentValues
+ assertThat(isDiff).isTrue();
+ assertThat(cv.getAsInteger(apnEnabledKey)).isEqualTo(apnEnabledValue);
+ }
+
+ @Test
+ public void testSetIntValue_valueNotChanged_shouldNotSetValue() {
+ // GIVEN a value indicated whether the apn is enabled, and it's same as the one in the
+ // database
+ final String apnEnabledKey = "apn_enabled";
+ final int apnEnabledValue = (int) APN_DATA[ApnEditor.CARRIER_ENABLED_INDEX];
+ final ContentValues cv = new ContentValues();
+
+ // WHEN try to check and set the apn enabled
+ final boolean isDiff = mApnEditorUT.setIntValueAndCheckIfDiff(
+ cv,
+ apnEnabledKey,
+ apnEnabledValue,
+ false /* assumeDiff */,
+ ApnEditor.CARRIER_ENABLED_INDEX);
+
+ // THEN the apn enabled field is same as the one in the database, and the filed is not
+ // stored in the given ContentValues
+ assertThat(isDiff).isFalse();
+ assertThat(cv.get(apnEnabledKey)).isNull();
+ }
+
+ @Test
+ public void testValidateApnData_validData_shouldReturnNull() {
+ // GIVEN a valid apn data
+ mApnEditorUT.mApnData = new FakeApnData(APN_DATA);
+ mApnEditorUT.fillUI(true /* firstTime */);
+
+ // WHEN validate the apn data
+ final String errMsg = mApnEditorUT.validateApnData();
+
+ // THEN the error message should be null
+ assertThat(errMsg).isNull();
+ }
+
+ @Test
+ public void testValidateApn_apnNameNotSet_shouldReturnErrorMessage() {
+ // GIVEN a apn data without the apn name
+ final FakeApnData apnData = new FakeApnData(APN_DATA);
+ apnData.mData[ApnEditor.NAME_INDEX] = "";
+ mApnEditorUT.mApnData = apnData;
+ mApnEditorUT.fillUI(true /* firstTime */);
+
+ // THEN validate the apn data
+ final String errMsg = mApnEditorUT.validateApnData();
+
+ // THEN the error message indicated the apn name not set is returned
+ assertThat(errMsg).isEqualTo(mResources.getString(R.string.error_name_empty));
+ }
+
+ @Test
+ public void testValidateApnData_apnNotSet_shouldReturnErrorMessage() {
+ // GIVEN a apn data without the apn
+ final FakeApnData apnData = new FakeApnData(APN_DATA);
+ apnData.mData[ApnEditor.APN_INDEX] = "";
+ mApnEditorUT.mApnData = apnData;
+ mApnEditorUT.fillUI(true /* firstTime */);
+
+ // THEN validate the apn data
+ final String errMsg = mApnEditorUT.validateApnData();
+
+ // THEN the error message indicated the apn not set is returned
+ assertThat(errMsg).isEqualTo(mResources.getString(R.string.error_apn_empty));
+ }
+
+ @Test
+ public void testValidateApnData_mccInvalid_shouldReturnErrorMessage() {
+ // GIVEN a apn data with invalid mcc
+ final FakeApnData apnData = new FakeApnData(APN_DATA);
+ // The length of the mcc should be 3
+ apnData.mData[ApnEditor.MCC_INDEX] = "1324";
+ mApnEditorUT.mApnData = apnData;
+ mApnEditorUT.fillUI(true /* firstTime */);
+
+ // WHEN validate the apn data
+ final String errMsg = mApnEditorUT.validateApnData();
+
+ // THEN the error message indicated the mcc invalid is returned
+ assertThat(errMsg).isEqualTo(mResources.getString(R.string.error_mcc_not3));
+ }
+
+ @Test
+ public void testValidateApnData_mncInvalid_shouldReturnErrorMessage() {
+ // GIVEN an apn data with invalid mnc
+ final FakeApnData apnData = new FakeApnData(APN_DATA);
+ // The length of the mnc should be 2 or 3
+ apnData.mData[ApnEditor.MNC_INDEX] = "1324";
+ mApnEditorUT.mApnData = apnData;
+ mApnEditorUT.fillUI(true /* firstTime */);
+
+ // WHEN validate the apn data
+ final String errMsg = mApnEditorUT.validateApnData();
+
+ // THEN the error message indicated the mnc invalid is returned
+ assertThat(errMsg).isEqualTo(mResources.getString(R.string.error_mnc_not23));
+ }
+
+ @Test
+ public void testSaveApnData_pressBackButtonWithValidApnData_shouldSaveApnData() {
+ // GIVEN a valid apn data
+ mApnEditorUT.mApnData = new FakeApnData(APN_DATA);
+ mApnEditorUT.fillUI(true /* firstTime */);
+
+ // WHEN press the back button
+ final KeyEvent event = new KeyEvent(KeyEvent.ACTION_DOWN, KeyEvent.KEYCODE_BACK);
+ mApnEditorUT.onKey(new View(mActivity), KeyEvent.KEYCODE_BACK, event);
+
+ // THEN the apn data is saved and the apn editor is closed
+ verify(mApnEditorUT).validateAndSaveApnData();
+ verify(mApnEditorUT).finish();
+ }
+
+ @Test
+ public void testSaveApnData_pressSaveButtonWithValidApnData_shouldSaveApnData() {
+ // GIVEN a valid apn data
+ mApnEditorUT.mApnData = new FakeApnData(APN_DATA);
+ mApnEditorUT.fillUI(true /* firstTime */);
+
+ // WHEN press the save button
+ MenuItem item = Mockito.mock(MenuItem.class);
+ // Menu.FIRST + 1 indicated the SAVE option in ApnEditor
+ doReturn(Menu.FIRST + 1).when(item).getItemId();
+ mApnEditorUT.onOptionsItemSelected(item);
+
+ // THEN the apn data is saved and the apn editor is closed
+ verify(mApnEditorUT).validateAndSaveApnData();
+ verify(mApnEditorUT).finish();
+ }
+
+ @Test
+ public void testSaveApnData_apnDataInvalid_shouldNotSaveApnData() {
+ // GIVEN an invalid apn data
+ final FakeApnData apnData = new FakeApnData(APN_DATA);
+ // The valid apn data should contains a non-empty apn name
+ apnData.mData[ApnEditor.NAME_INDEX] = "";
+ mApnEditorUT.mApnData = apnData;
+ mApnEditorUT.fillUI(true /* firstTime */);
+
+ // WHEN press the save button
+ final MenuItem item = Mockito.mock(MenuItem.class);
+ // Menu.FIRST + 1 indicated the SAVE option in ApnEditor
+ doReturn(Menu.FIRST + 1).when(item).getItemId();
+ mApnEditorUT.onOptionsItemSelected(item);
+
+ // THEN the error dialog is shown
+ verify(mApnEditorUT).validateAndSaveApnData();
+ verify(mApnEditorUT).showError();
+ }
+
+ @Test
+ public void testDeleteApnData_shouldDeleteData() {
+ // GIVEN a valid apn data correspond a row in database
+ final Uri apnUri = Uri.parse("content://telephony/carriers/1");
+ mApnEditorUT.mApnData = new FakeApnData(APN_DATA, apnUri);
+ mApnEditorUT.fillUI(true /* firstTime */);
+ ContentResolver mockContentResolver = Mockito.mock(ContentResolver.class);
+ doReturn(mockContentResolver).when(mActivity).getContentResolver();
+
+ // WHEN press the save button
+ final MenuItem item = Mockito.mock(MenuItem.class);
+ // Menu.FIRST indicated the DELETE option in ApnEditor
+ doReturn(Menu.FIRST).when(item).getItemId();
+ mApnEditorUT.onOptionsItemSelected(item);
+
+ // THEN the apn data is deleted and the apn editor is closed
+ verify(mockContentResolver).delete(mUriCaptor.capture(), any(), any());
+ assertThat(apnUri).isEqualTo(mUriCaptor.getValue());
+ verify(mApnEditorUT).finish();
+ }
+
+ @Test(expected = ClassCastException.class)
public void testApnData_invalidIntegerType_throwsInvalidTypeException() {
// GIVEN a ApnData constructed from cursor
- ApnData data = new ApnData(mApnUri, mCursor);
+ initCursor();
+ final ApnData data = new ApnData(mApnUri, mCursor);
// WHEN get a string from an integer column
// THEN the InvalidTypeException is threw
data.getString(CURSOR_INTEGER_INDEX);
}
- @Test(expected = InvalidTypeException.class)
+ @Test(expected = ClassCastException.class)
public void testApnData_invalidStringType_throwsInvalidTypeException() {
// GIVEN a ApnData constructed from cursor
- ApnData data = new ApnData(mApnUri, mCursor);
+ initCursor();
+ final ApnData data = new ApnData(mApnUri, mCursor);
// WHEN get a integer from a string column
// THEN the InvalidTypeException is threw
@Test
public void testApnData_validIntegerType_returnCorrectValue() {
// GIVEN a ApnData constructed from cursor
- ApnData data = new ApnData(mApnUri, mCursor);
+ initCursor();
+ final ApnData data = new ApnData(mApnUri, mCursor);
// WHEN get integer from an integer column
- int val = data.getInteger(CURSOR_INTEGER_INDEX);
+ final int val = data.getInteger(CURSOR_INTEGER_INDEX);
// THEN the integer is returned correctly
- assertEquals(mCursor.getInt(CURSOR_INTEGER_INDEX), val);
+ assertThat(val).isEqualTo(mCursor.getInt(CURSOR_INTEGER_INDEX));
}
@Test
public void testApnData_validStringType_returnCorrectValue() {
// GIVEN a ApnData constructed from cursor
- ApnData data = new ApnData(mApnUri, mCursor);
+ initCursor();
+ final ApnData data = new ApnData(mApnUri, mCursor);
// WHEN get string from a string column
- String str = data.getString(CURSOR_STRING_INDEX);
+ final String str = data.getString(CURSOR_STRING_INDEX);
// THEN the integer is returned correctly
- assertEquals(mCursor.getString(CURSOR_STRING_INDEX), str);
+ assertThat(str).isEqualTo(mCursor.getString(CURSOR_STRING_INDEX));
}
@Test
public void testApnData_nullValueColumn_returnNull() {
// GIVEN a empty ApnData
- ApnData data = new ApnData(3);
+ final ApnData data = new ApnData(3);
// WHEN get string value from a null column
- String str = data.getString(0);
+ final String str = data.getString(0);
// THEN the null value is returned
- assertNull(str);
+ assertThat(str).isNull();
+ }
+
+ private void initCursor() {
+ doReturn(2).when(mCursor).getColumnCount();
+ doReturn(Integer.valueOf(2)).when(mCursor).getInt(CURSOR_INTEGER_INDEX);
+ doReturn("str").when(mCursor).getString(CURSOR_STRING_INDEX);
+ doReturn(Cursor.FIELD_TYPE_INTEGER).when(mCursor).getType(CURSOR_INTEGER_INDEX);
+ doReturn(Cursor.FIELD_TYPE_STRING).when(mCursor).getType(CURSOR_STRING_INDEX);
+ }
+
+ private void setMockPreference(Context context) {
+ mApnEditorUT.mName = new EditTextPreference(context);
+ mApnEditorUT.mApn = new EditTextPreference(context);
+ mApnEditorUT.mProxy = new EditTextPreference(context);
+ mApnEditorUT.mPort = new EditTextPreference(context);
+ mApnEditorUT.mUser = new EditTextPreference(context);
+ mApnEditorUT.mServer = new EditTextPreference(context);
+ mApnEditorUT.mPassword = new EditTextPreference(context);
+ mApnEditorUT.mMmsc = new EditTextPreference(context);
+ mApnEditorUT.mMcc = new EditTextPreference(context);
+ mApnEditorUT.mMnc = new EditTextPreference(context);
+ mApnEditorUT.mMmsProxy = new EditTextPreference(context);
+ mApnEditorUT.mMmsPort = new EditTextPreference(context);
+ mApnEditorUT.mAuthType = new ListPreference(context);
+ mApnEditorUT.mApnType = new EditTextPreference(context);
+ mApnEditorUT.mProtocol = new ListPreference(context);
+ mApnEditorUT.mRoamingProtocol = new ListPreference(context);
+ mApnEditorUT.mCarrierEnabled = new SwitchPreference(context);
+ mApnEditorUT.mBearerMulti = new MultiSelectListPreference(context);
+ mApnEditorUT.mMvnoType = new ListPreference(context);
+ mApnEditorUT.mMvnoMatchData = new EditTextPreference(context);
+ }
+
+ private final class FakeApnData extends ApnData {
+ FakeApnData(Object[] data) {
+ super(data.length);
+ System.arraycopy(data, 0, mData, 0, data.length);
+ }
+
+ FakeApnData(Object[] data, Uri uri) {
+ this(data);
+ mUri = uri;
+ }
}
-}
+}
\ No newline at end of file
OSDN Git Service
