OSDN Git Service

can: softing: softing_netdev_open(): remove redundant ret variable
authorMinghao Chi <chi.minghao@zte.com.cn>
Wed, 12 Jan 2022 08:06:29 +0000 (08:06 +0000)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 24 Feb 2022 07:26:04 +0000 (08:26 +0100)
Return value from softing_startstop() directly instead of taking this
in another redundant variable.

Link: https://lore.kernel.org/all/20220112080629.667191-1-chi.minghao@zte.com.cn
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/softing/softing_main.c

index d74e895..8d27ac6 100644 (file)
@@ -392,13 +392,10 @@ static int softing_netdev_open(struct net_device *ndev)
 
 static int softing_netdev_stop(struct net_device *ndev)
 {
-       int ret;
-
        netif_stop_queue(ndev);
 
        /* softing cycle does close_candev() */
-       ret = softing_startstop(ndev, 0);
-       return ret;
+       return softing_startstop(ndev, 0);
 }
 
 static int softing_candev_set_mode(struct net_device *ndev, enum can_mode mode)