OSDN Git Service

erspan: Check IFLA_GRE_ERSPAN_VER is set.
authorWilliam Tu <u9012063@gmail.com>
Tue, 12 May 2020 17:36:23 +0000 (10:36 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 May 2020 20:11:41 +0000 (13:11 -0700)
Add a check to make sure the IFLA_GRE_ERSPAN_VER is provided by users.

Fixes: f989d546a2d5 ("erspan: Add type I version 0 support.")
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: William Tu <u9012063@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_gre.c

index e29cd48..0ce9b91 100644 (file)
@@ -1087,7 +1087,8 @@ static int erspan_validate(struct nlattr *tb[], struct nlattr *data[],
        if (ret)
                return ret;
 
-       if (nla_get_u8(data[IFLA_GRE_ERSPAN_VER]) == 0)
+       if (data[IFLA_GRE_ERSPAN_VER] &&
+           nla_get_u8(data[IFLA_GRE_ERSPAN_VER]) == 0)
                return 0;
 
        /* ERSPAN type II/III should only have GRE sequence and key flag */