OSDN Git Service

media: ccs: Wait until software reset is done
authorSakari Ailus <sakari.ailus@linux.intel.com>
Thu, 8 Oct 2020 10:09:07 +0000 (12:09 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 12 Jan 2021 16:50:10 +0000 (17:50 +0100)
Verify the software reset has been completed until proceeding.

The spec does not guarantee a delay but presumably 100 ms should be
enough.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ccs/ccs-core.c

index fdf2e83..e1b3c56 100644 (file)
@@ -1553,11 +1553,26 @@ static int ccs_power_on(struct device *dev)
         */
 
        if (!sensor->reset && !sensor->xshutdown) {
+               u8 retry = 100;
+               u32 reset;
+
                rval = ccs_write(sensor, SOFTWARE_RESET, CCS_SOFTWARE_RESET_ON);
                if (rval < 0) {
                        dev_err(dev, "software reset failed\n");
                        goto out_cci_addr_fail;
                }
+
+               do {
+                       rval = ccs_read(sensor, SOFTWARE_RESET, &reset);
+                       reset = !rval && reset == CCS_SOFTWARE_RESET_OFF;
+                       if (reset)
+                               break;
+
+                       usleep_range(1000, 2000);
+               } while (--retry);
+
+               if (!reset)
+                       return -EIO;
        }
 
        if (sensor->hwcfg.i2c_addr_alt) {