OSDN Git Service

pinctrl: renesas: rzg2l: Return -EINVAL for pins which have input disabled
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Wed, 11 May 2022 09:40:57 +0000 (10:40 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 6 Jun 2022 09:12:22 +0000 (11:12 +0200)
Pin status reported by pinconf-pins file always reported pin status as
"input enabled" even for pins which had input disabled. Fix this by
returning -EINVAL for the pins which have input disabled.

Fixes: c4c4637eb57f2 ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver")
Reported-by: Phil Edworthy <phil.edworthy@renesas.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Phil Edworthy <phil.edworthy@renesas.com>
Link: https://lore.kernel.org/r/20220511094057.3151-1-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/renesas/pinctrl-rzg2l.c

index a48cac5..c3cdf52 100644 (file)
@@ -517,6 +517,8 @@ static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
                if (!(cfg & PIN_CFG_IEN))
                        return -EINVAL;
                arg = rzg2l_read_pin_config(pctrl, IEN(port_offset), bit, IEN_MASK);
+               if (!arg)
+                       return -EINVAL;
                break;
 
        case PIN_CONFIG_POWER_SOURCE: {