OSDN Git Service

fm10k: add missing fall through comment
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 10 Jul 2017 20:23:07 +0000 (13:23 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 2 Oct 2017 14:54:00 +0000 (07:54 -0700)
Newer versions of GCC starting with 7 now additionally warn when a case
statement may fall through without an explicit comment mentioning it.
Add such a comment to silence the warning, as this is expected.

Unfortunately the comment must come directly before the next case
statement, so we put it outside the #ifdef. Otherwise, the compiler
cannot properly detect it and thus the warning is displayed regardless.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_main.c

index 9dffaba..189d52a 100644 (file)
@@ -876,6 +876,7 @@ static void fm10k_tx_csum(struct fm10k_ring *tx_ring,
        case IPPROTO_GRE:
                if (skb->encapsulation)
                        break;
+               /* fall through */
        default:
                if (unlikely(net_ratelimit())) {
                        dev_warn(tx_ring->dev,