OSDN Git Service

blk-iolatency: fix blkg leak in timer_fn
authorJosef Bacik <josef@toxicpanda.com>
Tue, 31 Jul 2018 16:39:02 +0000 (12:39 -0400)
committerJens Axboe <axboe@kernel.dk>
Wed, 1 Aug 2018 15:16:01 +0000 (09:16 -0600)
At this point we have a ref on the blkg, we need to drop it if we don't
have a iolat.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iolatency.c

index bb59b29..b0dc4fc 100644 (file)
@@ -627,7 +627,7 @@ static void blkiolatency_timer_fn(struct timer_list *t)
 
                iolat = blkg_to_lat(blkg);
                if (!iolat)
-                       continue;
+                       goto next;
 
                lat_info = &iolat->child_lat;
                cookie = atomic_read(&lat_info->scale_cookie);