OSDN Git Service

fsi: scom: Remove PIB reset during probe
authorEddie James <eajames@linux.vnet.ibm.com>
Tue, 8 May 2018 22:43:32 +0000 (17:43 -0500)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 12 Jun 2018 04:05:34 +0000 (14:05 +1000)
The PIB reset causes problems for the running P9 chip. The reset
shouldn't be performed by this driver.

Signed-off-by: Eddie James <eajames@linux.vnet.ibm.com>
Reviewed-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Tested-by: Joel Stanley <joel@jms.id.au>
drivers/fsi/fsi-scom.c

index e13353a..c8eb5e5 100644 (file)
 
 #define FSI_ENGID_SCOM         0x5
 
-#define SCOM_FSI2PIB_DELAY     50
-
 /* SCOM engine register set */
 #define SCOM_DATA0_REG         0x00
 #define SCOM_DATA1_REG         0x04
 #define SCOM_CMD_REG           0x08
-#define SCOM_RESET_REG         0x1C
 
-#define SCOM_RESET_CMD         0x80000000
 #define SCOM_WRITE_CMD         0x80000000
 
 struct scom_device {
@@ -180,7 +176,6 @@ static const struct file_operations scom_fops = {
 
 static int scom_probe(struct device *dev)
 {
-       uint32_t data;
        struct fsi_device *fsi_dev = to_fsi_dev(dev);
        struct scom_device *scom;
 
@@ -197,9 +192,6 @@ static int scom_probe(struct device *dev)
        scom->mdev.parent = dev;
        list_add(&scom->link, &scom_devices);
 
-       data = cpu_to_be32(SCOM_RESET_CMD);
-       fsi_device_write(fsi_dev, SCOM_RESET_REG, &data, sizeof(uint32_t));
-
        return misc_register(&scom->mdev);
 }