OSDN Git Service

clk: socfpga: remove redundant initialization of variable div
authorColin Ian King <colin.king@canonical.com>
Tue, 6 Apr 2021 18:27:46 +0000 (19:27 +0100)
committerStephen Boyd <sboyd@kernel.org>
Wed, 7 Apr 2021 23:30:23 +0000 (16:30 -0700)
The variable div is being initialized with a value that is
never read and it is being updated later with a new value.  The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210406182746.432861-1-colin.king@canonical.com
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/socfpga/clk-gate-s10.c
drivers/clk/socfpga/clk-pll-s10.c

index f9f403d..b84f262 100644 (file)
@@ -31,7 +31,7 @@ static unsigned long socfpga_dbg_clk_recalc_rate(struct clk_hw *hwclk,
                                                  unsigned long parent_rate)
 {
        struct socfpga_gate_clk *socfpgaclk = to_socfpga_gate_clk(hwclk);
-       u32 div = 1, val;
+       u32 div, val;
 
        val = readl(socfpgaclk->div_reg) >> socfpgaclk->shift;
        val &= GENMASK(socfpgaclk->width - 1, 0);
index bc37461..70076a8 100644 (file)
@@ -107,7 +107,7 @@ static unsigned long clk_boot_clk_recalc_rate(struct clk_hw *hwclk,
                                         unsigned long parent_rate)
 {
        struct socfpga_pll *socfpgaclk = to_socfpga_clk(hwclk);
-       u32 div = 1;
+       u32 div;
 
        div = ((readl(socfpgaclk->hw.reg) &
                SWCTRLBTCLKSEL_MASK) >>