OSDN Git Service

KVM: X86: Add 'else' to unify fastop and execute call path
authorMiaohe Lin <linmiaohe@huawei.com>
Wed, 22 Jan 2020 03:21:44 +0000 (11:21 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 27 Jan 2020 19:00:11 +0000 (20:00 +0100)
It also helps eliminate some duplicated code.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/emulate.c

index c7a0da4..0accce9 100644 (file)
@@ -5683,11 +5683,9 @@ special_insn:
                if (ctxt->d & Fastop) {
                        void (*fop)(struct fastop *) = (void *)ctxt->execute;
                        rc = fastop(ctxt, fop);
-                       if (rc != X86EMUL_CONTINUE)
-                               goto done;
-                       goto writeback;
+               } else {
+                       rc = ctxt->execute(ctxt);
                }
-               rc = ctxt->execute(ctxt);
                if (rc != X86EMUL_CONTINUE)
                        goto done;
                goto writeback;