OSDN Git Service

construct QVarLengthArray<T>() with the right size instead of resizing it in QDBusMet...
authorIvailo Monev <xakepa10@gmail.com>
Mon, 4 Oct 2021 06:30:04 +0000 (09:30 +0300)
committerIvailo Monev <xakepa10@gmail.com>
Mon, 4 Oct 2021 06:30:04 +0000 (09:30 +0300)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
src/dbus/qdbusmetaobject.cpp

index f72d26d..b214e36 100644 (file)
@@ -343,8 +343,8 @@ void QDBusMetaObjectGenerator::write(QDBusMetaObject *obj)
     if (className.isEmpty())
         className = QLatin1String("QDBusInterface");
 
-    QVarLengthArray<int> idata;
-    idata.resize(sizeof(QDBusMetaObjectPrivate) / sizeof(int));
+    static const int QDBusMetaObjectPrivateSize = (sizeof(QDBusMetaObjectPrivate) / sizeof(int));
+    QVarLengthArray<int> idata(QDBusMetaObjectPrivateSize);
 
     QDBusMetaObjectPrivate *header = reinterpret_cast<QDBusMetaObjectPrivate *>(idata.data());
     header->revision = qmetaobjectrevision;