OSDN Git Service

platform/chrome: cros_ec_typec: Correct the Thunderbolt rounded/non-rounded cable...
authorUtkarsh Patel <utkarsh.h.patel@intel.com>
Fri, 13 Nov 2020 20:24:57 +0000 (12:24 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Nov 2020 11:53:45 +0000 (12:53 +0100)
Thunderbolt rounded/non-rounded cable support is two bits value. Correcting
it as per the Thunderbolt 3 cable discover mode VDO changes done in the
Thunderbolt 3 alternate mode header.

Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
--
Changes in v2:
- Removed the fixes tag as there is no functional implication.
--
Link: https://lore.kernel.org/r/20201113202503.6559-3-utkarsh.h.patel@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/platform/chrome/cros_ec_typec.c

index 31be311..8111ed1 100644 (file)
@@ -438,8 +438,7 @@ static int cros_typec_enable_tbt(struct cros_typec_data *typec,
        if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_LINK_UNIDIR)
                data.cable_mode |= TBT_CABLE_LINK_TRAINING;
 
-       if (pd_ctrl->cable_gen)
-               data.cable_mode |= TBT_CABLE_ROUNDED;
+       data.cable_mode |= TBT_SET_CABLE_ROUNDED(pd_ctrl->cable_gen);
 
        /* Enter Mode VDO */
        data.enter_vdo = TBT_SET_CABLE_SPEED(pd_ctrl->cable_speed);