OSDN Git Service

kselftest/cgroup: fix a signedness bug
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 7 Jun 2018 08:30:02 +0000 (11:30 +0300)
committerShuah Khan (Samsung OSG) <shuah@kernel.org>
Thu, 7 Jun 2018 19:44:30 +0000 (13:44 -0600)
"len" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
tools/testing/selftests/cgroup/cgroup_util.c

index b69bdeb..1e9e3c4 100644 (file)
@@ -35,7 +35,7 @@ out:
        return len;
 }
 
-static ssize_t write_text(const char *path, char *buf, size_t len)
+static ssize_t write_text(const char *path, char *buf, ssize_t len)
 {
        int fd;
 
@@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
 int cg_write(const char *cgroup, const char *control, char *buf)
 {
        char path[PATH_MAX];
-       size_t len = strlen(buf);
+       ssize_t len = strlen(buf);
 
        snprintf(path, sizeof(path), "%s/%s", cgroup, control);