* fhandler_process.cc (fhandler_process::fill_filebuf): Open pinfo with

PID_MAP_RW.
* sigproc.cc (talktome): Ditto for winpids.

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index a7ef9a7..2725400 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,5 +1,11 @@
 2003-09-16  Christopher Faylor  <cgf@redhat.com>
 
+       * fhandler_process.cc (fhandler_process::fill_filebuf): Open pinfo with
+       PID_MAP_RW.
+       * sigproc.cc (talktome): Ditto for winpids.
+
+2003-09-16  Christopher Faylor  <cgf@redhat.com>
+
        * pinfo.h (winpids::pid_access): New element.
        (winpids::winpids): Rejigger to set pinfo_access.
        * pinfo.cc (winpids::add): Try to open shared memory region with

diff --git a/winsup/cygwin/fhandler_process.cc b/winsup/cygwin/fhandler_process.cc
index 44b7189..2ba1e53 100644 (file)
--- a/winsup/cygwin/fhandler_process.cc
+++ b/winsup/cygwin/fhandler_process.cc
@@ -245,7 +245,8 @@ out:
 bool
 fhandler_process::fill_filebuf ()
 {
-  pinfo p (pid);
+  pinfo p (pid, PID_MAP_RW);   // PID_MAP_RW for cmdline since it
+                               // needs to signal the other process
 
   if (!p)
     {

diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
index dff0730..6c53937 100644 (file)
--- a/winsup/cygwin/sigproc.cc
+++ b/winsup/cygwin/sigproc.cc
@@ -1056,10 +1056,11 @@ stopped_or_terminated (waitq *parent_w, _pinfo *child)
 static void
 talktome ()
 {
-  winpids pids;
+  winpids pids ((DWORD) PID_MAP_RW);
   for (unsigned i = 0; i < pids.npids; i++)
     if (pids[i]->hello_pid == myself->pid)
-      pids[i]->commune_recv ();
+      if (!IsBadWritePtr (pids[i], sizeof (_pinfo)))
+       pids[i]->commune_recv ();
 }
 
 #define RC_MAIN 0