OSDN Git Service

cxgb4: Fix endian bug introduced in cxgb4 dcb patchset
authorAnish Bhatt <anish@chelsio.com>
Tue, 24 Jun 2014 06:11:09 +0000 (23:11 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Jun 2014 19:54:52 +0000 (12:54 -0700)
Hi,
 This patch fixes warnings generated by sparse as pointed out by kbuild test
 robot, please apply to net-next. Applies on top of
commit 79631c89ed70643fd0579a65834b227795b251ee ("trivial: net/irda/irlmp.c:
Fix closing brace followed by if")
-Anish

v2: cleanup submission as per davem's feedback

Fixes: 76bcb31efc06 ("cxgb4 : Add DCBx support codebase  and dcbnl_ops")
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c

index 39b4a85..a8b1073 100644 (file)
@@ -488,12 +488,12 @@ static void cxgb4_setpfccfg(struct net_device *dev, int priority, u8 pfccfg)
                pcmd.op_to_portid |= cpu_to_be32(FW_PORT_CMD_APPLY);
 
        pcmd.u.dcb.pfc.type = FW_PORT_DCB_TYPE_PFC;
-       pcmd.u.dcb.pfc.pfcen = cpu_to_be16(pi->dcb.pfcen);
+       pcmd.u.dcb.pfc.pfcen = pi->dcb.pfcen;
 
        if (pfccfg)
-               pcmd.u.dcb.pfc.pfcen |= cpu_to_be16(1 << priority);
+               pcmd.u.dcb.pfc.pfcen |= (1 << priority);
        else
-               pcmd.u.dcb.pfc.pfcen &= cpu_to_be16(~(1 << priority));
+               pcmd.u.dcb.pfc.pfcen &= (~(1 << priority));
 
        err = t4_wr_mbox(adap, adap->mbox, &pcmd, sizeof(pcmd), &pcmd);
        if (err != FW_PORT_DCB_CFG_SUCCESS) {
@@ -501,7 +501,7 @@ static void cxgb4_setpfccfg(struct net_device *dev, int priority, u8 pfccfg)
                return;
        }
 
-       pi->dcb.pfcen = be16_to_cpu(pcmd.u.dcb.pfc.pfcen);
+       pi->dcb.pfcen = pcmd.u.dcb.pfc.pfcen;
 }
 
 static u8 cxgb4_setall(struct net_device *dev)