OSDN Git Service

memstick/ms_block: Fix a memory leak
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 25 Jun 2022 12:55:56 +0000 (14:55 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 12 Jul 2022 10:29:36 +0000 (12:29 +0200)
'erased_blocks_bitmap' is never freed. As it is allocated at the same time
as 'used_blocks_bitmap', it is likely that it should be freed also at the
same time.

Add the corresponding bitmap_free() in msb_data_clear().

Fixes: 0ab30494bc4f ("memstick: add support for legacy memorysticks")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/b3b78926569445962ea5c3b6e9102418a9effb88.1656155715.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/memstick/core/ms_block.c

index f8f1511..f8fdf88 100644 (file)
@@ -1947,6 +1947,7 @@ static void msb_data_clear(struct msb_data *msb)
 {
        kfree(msb->boot_page);
        bitmap_free(msb->used_blocks_bitmap);
+       bitmap_free(msb->erased_blocks_bitmap);
        kfree(msb->lba_to_pba_table);
        kfree(msb->cache);
        msb->card = NULL;