OSDN Git Service

Fixed log warning for calling doStart() twice.
authorGeorge Mount <mount@google.com>
Thu, 23 Mar 2017 16:08:49 +0000 (09:08 -0700)
committerGeorge Mount <mount@google.com>
Thu, 23 Mar 2017 16:08:49 +0000 (09:08 -0700)
Bug 36504927

The LoaderManager was performing a doStart() multiple times
and issued a warning and then returned without any problems.
This CL fixes the underlying problem of doStart() being
called multiple times so that the warning isn't logged.

Test: ran fragment cts tests
Change-Id: I4a43280fd581e08ccd911d8d05367e00382d694a

core/java/android/app/Fragment.java

index eff77b5..44fefd3 100644 (file)
@@ -1670,8 +1670,7 @@ public class Fragment implements ComponentCallbacks2, OnCreateContextMenuListene
             if (!mCheckedForLoaderManager) {
                 mCheckedForLoaderManager = true;
                 mLoaderManager = mHost.getLoaderManager(mWho, mLoadersStarted, false);
-            }
-            if (mLoaderManager != null) {
+            } else if (mLoaderManager != null) {
                 mLoaderManager.doStart();
             }
         }